Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_fields] Fix front end articles category switch #17872

Merged

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Sep 5, 2017

Pull Request for Issue #17867.

Summary of Changes

Changing the category when editing an article redirects to the start page. This pr fixes that bug.

Testing Instructions

  • Log in on the back end
  • Create a second category for an article
  • Create an article with the title DEMO and give the Registered and Author groups edit and edit state right
  • Create a new user which is assigned to the Registered and Author group, NO super admin
  • Log in on the front with this new user
  • Edit the article with the title DEMO
  • Open the publishing tab
  • Change the category

Expected result

The edit form is reloaded.

Actual result

It redirects to the wrong url.

@ghost
Copy link

ghost commented Sep 5, 2017

@GCLW one more (last one):

  • Please open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as (un)successfully
  • hit "submit test result"

@GCLW
Copy link

GCLW commented Sep 5, 2017

I have tested this item 🔴 unsuccessfully on bb8c950

Installed 3.8.0-beta4 locally with sample data.
Replaced the two files that cover the fix.
Setup a user that is Registered and an Author.
Created a custom field under content; just keeping default params
logged into the front end of the website, clicked on the "Create an Article" menu item.
Clicked on the Publishing tab.
Clicked on the Category dropdown and changed it from "Uncategorised" to "News", the overlay occurs and the page is then redirected from: index.php/create-an-article to: index.php/create-an-article?view=categories

Same issue as before.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17872.

@laoneo
Copy link
Member Author

laoneo commented Sep 5, 2017

Did it work when editing an article? Can you also test with the latest staging?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17872.

@GCLW
Copy link

GCLW commented Sep 5, 2017

It works when editing an article.
If I create an article and leave the category set to "Uncategorized", save it. And edit the article I can change the category dropdown without issue.
All done through the front end.

I honestly thought I did select the most recent version of 3.8 (beta 4)

@wojsmol
Copy link
Contributor

wojsmol commented Sep 5, 2017

@GCLW Please test on staging branch

@laoneo
Copy link
Member Author

laoneo commented Sep 6, 2017

Can you please test it again as it should work now with adding an article.

@laoneo
Copy link
Member Author

laoneo commented Sep 6, 2017

You need to mark it as successful on issues.joomla.org

@GCLW
Copy link

GCLW commented Sep 6, 2017

I have tested this item ✅ successfully on 07888d2

After testing on the latest staging 3.8.0 with this fix, I am now able to change categories on the front end when creating or editing an article with Registered and Author privileges.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17872.

@ghost
Copy link

ghost commented Sep 6, 2017

Didn't get this issue: On clean Installation and settings like described above change an Article-Category from "en-gb" to "de-at" works without Pull Request as expected.

System information

3.8.0-rc1-dev
Multilanguage Site
macOS Sierra, 10.12.6
Firefox 55 (64-bit)

MAMP 4.1.1

  • PHP 7.0.15
  • MySQLi 5.6.35

@laoneo
Copy link
Member Author

laoneo commented Sep 6, 2017

Are you a none super admin user?

@ghost
Copy link

ghost commented Sep 6, 2017

Logged-in as User which is assigned to the Registered and Author group.

@GCLW
Copy link

GCLW commented Sep 6, 2017

This pertains to front end article creation and editing by a user with Registered and Author permissions.
and you need at least one custom field created. That is the key to the error.

@ghost
Copy link

ghost commented Sep 6, 2017

Haven't a custom Field used and created the Test-Article in Backend.

Will try with updated Instructions.

@ghost
Copy link

ghost commented Sep 6, 2017

I have tested this item ✅ successfully on 07888d2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17872.

@ghost
Copy link

ghost commented Sep 6, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 6, 2017
@mbabker mbabker added this to the Joomla 3.8.0 milestone Sep 7, 2017
@mbabker mbabker merged commit a072516 into joomla:staging Sep 7, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 7, 2017
@laoneo laoneo deleted the cf/fix/frontend-category-switch branch September 7, 2017 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants