Fix backend articles manager not listing articles in sub-categories when categories filter is active #18179

ggppdk · 2017-10-01T06:37:11Z

Pull Request for Issue #18178

Summary of Changes

Listing articles in sub-categories when categories filter is active is no longer working
This quite a big annoyance for people that need it,

also issue may go unnoticed by people that need

Bug was introduced when category filter in articles manager was converted to multi-value

multi value category filtering code does not support listing sub-category articles (yet)

This PR fixes

the very common case of filtering by a single category
but also fixes the case of selecting more than 1 category in the filter
also the (max) level filter is applied per filtered category

Testing Instructions

In a Joomla installation that e.g. has testing articles
filter by category "Joomla" and you will notice that only 11 articles are shown , those that belong to category "Joomla"

also please test with

2 categories without (max) level filter
2 categories with (max) level filter

Expected result

Those that belong to subcategories should also be listed (when max level filter is not set)

Actual result

Those that belong to subcategories are not listed (despite max level filter not set)

Documentation Changes Required

None

…hen categories filter has only 1 category

alikon · 2017-10-01T06:54:42Z

i don't think this fix is correct
cause now we can select based upon multiple categories selection
so
if i choose to select multiple categories only, for me means i don't want articles from subcategories
but only articles from the selected categories

degobbis · 2017-10-01T07:00:28Z

Even if this is perhaps just a side effect of the multi-select funtion, so I find that now better so. I have previously missed seeing only the articles of a category without subcategories. If you want to see the articles of the subcategories too, then better by selecting it additional.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18179.}

ggppdk · 2017-10-01T07:03:34Z

@alikon

The fix is very correct in terms that it restores the old and expected behaviour
(look at the code please)

when a single category is selected then we make use of category and the max-levels filter
when multi-categories are selected we only list in the selected categories

it is very bad UX to select a category and not be able list articles in sub-categories

In my own extension i have implemented also listing records in sub-categories even when selecting multiple categories (combining the max-level filter)

degobbis · 2017-10-01T07:20:07Z

To restore the old behavior, this patch is correct.
But I think it would be more logical to control the sub-categories with Max-Level when I want to see them. The selection of the category should only display those that were selected.
So I think the bug is that Max-Level does not change the display of the subcategories.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18179.}

alikon · 2017-10-01T07:29:06Z

@ggppdk in your own extensions you are free to do whatever you want,
in the core i think you are free to propose whatever you want, but we are all free to discuss proposal and even to have different opinion

ggppdk · 2017-10-01T07:36:25Z

@degobbis

What you describe about multiple categories,
is trade-off that was accepted when category filter was made multi-value

Doing what you ask is possible
by creating multiple lft and rgt limiting clauses that are glued with OR

but e.g. @alikon believes otherwise

only the specific categories should be listed and
e.g. the max-levels filter should be hidden or a message should be shown to the user once per login session that articles are listed only in the specific (multiple-selected) categories

also the max-levels filter in single category starts at the level of the category

in the case of multiple categories it should propably start at the top, meaning it may be a little confusing to the user
let's fix this nasty UX bug for single category
and not add something that in my opinion would be a new feature

ggppdk · 2017-10-01T11:09:51Z

@alikon

This is bug fix of previous / expected behaviour,
please forget me mentioning my extension
I mentioned it only to show that i have a little experience on the topic

Also i do not care so much for this PR,
we can just leave it broken and live with it
you can ask me to close it and i will do

alikon · 2017-10-01T18:24:39Z

@ggppdk
i 'll always never ask you to close a pr
"simply because i don't like it"
i've just expressed how i've understand that new feature/behaviour #17668
maybe should have been better to discuss more and more deeply that feature/behaviour (#17668) before to merge it

brianteeman · 2017-10-01T18:31:23Z

We have a UX team - why not let them make the decision?

alikon · 2017-10-01T18:57:22Z

👍

ggppdk · 2017-10-01T18:59:52Z

Sure,
my most important notes and questions are in this answer:
#18179 (comment)

how to behave with single category selected ?

handle it differently than selecting multiple categories

how to behave with multiple category selected ?

hide the max level filter ?
show a warning message once per session that articles in sub-categories are not shown ?

infograf768 · 2017-10-02T05:21:39Z

show a warning message once per session that articles in sub-categories are not shown ?

Not really in favour of that.
Suggestion if possible: a new filter to display sub-categories articles or not for all cases (single and multiple categories selected.

Bakual · 2017-10-02T05:44:18Z

Imho items from subcategories have to be shown when there is no level filter set. That is the old behavior and thus the expected one. Doesn't matter if one category is selected or multiple. The behavior has to be the same.
If you only want items from the selected categories, you set the level filter to 1. That's the point of that filter.

degobbis · 2017-10-02T06:18:01Z

In my opinion, with the multi-selective of the categories, the level filter field has become obsolete.
I can now choose my subcategories more flexibly than before.
What makes sense now would be a selection field for "show all subcategories".

For me personally this bug is welcome. Finally, ONLY the items appearing in the selected category are displayed.
This has always annoyed me before, still have to adjust the level for this.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18179.}

hrefferh · 2017-10-02T12:07:48Z

I have tested this item ✅ successfully on 92d7844

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18179.}

pickeboe · 2017-10-02T13:40:53Z

We discovered this bug too. Today a client and myself was wondering about the new "feature" or the bug. My client called me and asked me, where to find his articles, listed in sub categories of a higher category. I said him, he should use the filter field "max level filter". He did. But couldn't find the expected articles. Why? I tested it, and must agree to him: this filter has broken! I agree with Bakuals posting.

Irrespective of the multi category filter mode, the "max level filter" should work like before. This is very important!

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18179.}

ggppdk · 2017-10-02T14:55:12Z

Ok fixed previous behaviour for multiple categories too

now we will have J3.7.x behaviour in case of filtering by multiple categories

Fixed the max level filter is usage too,
by making it to be based on the deepest category

Quy · 2017-10-02T15:09:07Z

administrator/components/com_content/models/articles.php

+
+			$baselevel = 1;
+			$subcat_items_where = array();
+			foreach($categoryId as $filter_catid)


Add a space after foreach.

thanks for the review

Quy · 2017-10-02T15:09:59Z

administrator/components/com_content/models/articles.php

+					: $baselevel;
+				$subcat_items_where[] = '(c.lft >= ' . (int) $categoryTable->lft . ' AND c.rgt <= ' . (int) $categoryTable->rgt . ')';
+			}
+			$query->where(implode($subcat_items_where, ' OR '));


The parameters are reversed. It should be: $query->where(implode(' OR ', $subcat_items_where));

implode accepts them in this order too (historical reasons),
but yes better to place them as official function signature

infograf768 · 2017-10-02T15:21:11Z

My test:
I have 2 root categories, each of them having a sub category.

If I filter by these 2 root categories and do not define a level for Select Max Levels
articles belonging to the root and children categories DO display fine
If I set Select Max Levels to 1
I then loose the subcategory articles from the second category in the order they show in the filter. Here the sub category of Categoria (it-it) (it-IT).
But the articles form the first root categorie(fr-FR) subcategory DO display.

Note: I can't change the order of the root categories in the filter. I guess the order depends on their id.

I need to set Select Max Levels to 2 to get back the display of the articles belonging to the subcategory of Categoria (it-it) (it-IT)

ggppdk · 2017-10-02T17:28:19Z

@Quy , @infograf768

thanks for review, testing
i made a fix for depth level filter, and CS
please recheck / retest

hrefferh · 2017-10-03T15:12:26Z

I have tested this item 🔴 unsuccessfully on d1abe63

#18179 (comment)

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18179.}

ggppdk · 2017-10-03T16:09:23Z

@hrefferh

I think you have missed reading a part of the description
(when selecting multiple categories) the depth used is the depth of the depeest category

what you got was the expected / intended behaviour according to the above description

(the trade-off is that the max-level filter is now based on the deepest filtered category)

infograf768 · 2017-10-03T16:16:03Z

I have tested this item ✅ successfully on d1abe63

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18179.}

ggppdk · 2017-10-03T16:21:02Z

(the trade-off is that the max-level filter is now based on the deepest filtered category)

the alternative is to create 1 join to the categories DB table per category selected in the category filter
-- this way we will be able to distiguish the level per category selected

if you would want this, i could do

ggppdk · 2017-10-03T16:25:15Z

Another option to make this consistent is always use depth from top

hrefferh · 2017-10-03T16:53:51Z

@ggppdk

You maybe right.
But for me it is confusing that when I filter root + sub1sub1 [ level: 2 ] to get results of sub2sub1 and sub3sub1 too!?

root
  |          
  |          
  |sub1       |sub2     |sub3
     |        |         |
     |        |         |
     |sub1    |sub1     |sub1

ggppdk · 2017-10-03T17:29:25Z

yes i agree it can be confusing,

re-thinking of it , i think , maybe it is possible to do without extra joins
checking it

ggppdk · 2017-10-03T17:58:24Z

@hrefferh , @infograf768

done , now the (max) level filter is applied to every category individually
please retest

ggppdk · 2017-10-03T17:59:20Z

Also i found a bug in categories manager linking to article manager with wrong level filter, i will make a different PR

hrefferh · 2017-10-03T18:55:37Z

I have tested this item ✅ successfully on fc7803e

Bingo!

root + sub1sub1 [ level: 2 ] => 11 hits

sub1sub1 [ level: 2 ] => 23 hits

root + sub1sub1 [ level: 2 ] && sub1sub1 [ level: 2 ] => 34 hits - identical to single filtering

GREAT! THANK YOU AGAIN FOR YOUR EFFORTS!!!

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18179.}

ghost · 2017-10-03T19:38:47Z

@infograf768 can you please retest?

infograf768 · 2017-10-04T07:39:23Z

I have tested this item ✅ successfully on fc7803e

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18179.}

infograf768 · 2017-10-04T07:39:47Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18179.}

mbabker · 2017-10-05T12:14:11Z

administrator/components/com_content/models/articles.php

 		{
 			$categoryId = ArrayHelper::toInteger($categoryId);
-			$query->where('a.catid IN (' . implode(',', ArrayHelper::toInteger($categoryId)) . ')');
+			$categoryTable = JTable::getInstance('Category', 'JTable');
+			$subcat_items_where = array();


Variable should be camel case.

infograf768 · 2017-10-08T07:58:59Z

@mbabker
I guess this one can now get in.

bobr666 · 2017-11-30T09:29:07Z

I thought this fix was included in Joomla 3.8.2 but the feature still doesn't seem to be fixed

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18179.}

zero-24 · 2017-11-30T12:06:45Z

@bobr666 can you please open a new issue with that thing that don't work for you (please explain with as mach as possible detail) so we can keep track on open issues. Thanks!
https://github.com/joomla/joomla-cms/issues/new

sandstorm871 · 2018-03-28T12:47:32Z

I only noticed this on a site we just updated to 3.8.6 and seem the problem still persists?
I have a category blog link set to include subcategories - set to all, but only the articles from the parent category show.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18179.}

ggppdk · 2018-03-28T12:52:08Z

@sandstorm871

This was a fix for the DB model of the backend articles manager,
it is not related to filtering of the frontend views

sandstorm871 · 2018-03-28T12:56:06Z

Sorry, I misread this, I'll test further & start a new issue, as think this is a bug.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18179.}

Fix backend articles manager not listing articles in sub-categories w…

92d7844

…hen categories filter has only 1 category

joomla-cms-bot added the PR-staging label Oct 1, 2017

ggppdk mentioned this pull request Oct 1, 2017

Fix cases that a submitted form has a multiple-value category id field (e.g. a filtering form), causing notices in article / record forms #18176

Merged

ghost mentioned this pull request Oct 1, 2017

[J3.8.0] Backend articles manager, articles in subcategories are not listed when a category is selected in category filter #18178

Closed

alikon mentioned this pull request Oct 2, 2017

Modern routing and filter archive view #18186

Closed

ggppdk added 2 commits October 2, 2017 17:46

Fix issue in case of filtering by multiple categories too

7f4a399

Remove the no longer needed comment

179242d

ggppdk changed the title ~~Fix backend articles manager not listing articles in sub-categories when categories filter has only 1 category~~ Fix backend articles manager not listing articles in sub-categories when categories filter is active Oct 2, 2017

Quy reviewed Oct 2, 2017

View reviewed changes

Fixed level depth issue, and CS

c140d1a

Use level filter based on each category

fc7803e

ggppdk mentioned this pull request Oct 3, 2017

[Category manager] Fix level limit for links linking to every category articles to be 1 (only the category itself) #18214

Merged

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 4, 2017

infograf768 added this to the Joomla 3.8.2 milestone Oct 4, 2017

mbabker reviewed Oct 5, 2017

View reviewed changes

Make variable name be camelcase

162f956

wojsmol mentioned this pull request Oct 9, 2017

filter by category doesn't show sub-category any more #18284

Closed

mbabker merged commit 7116be3 into joomla:staging Oct 9, 2017

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 9, 2017

ggppdk mentioned this pull request Nov 6, 2017

backend category filtering #18511

Closed

ghost mentioned this pull request Dec 1, 2017

Sub-Categories not selected in Content-Articles view after 3.8.2 upgrade #18931

Closed

Fix backend articles manager not listing articles in sub-categories when categories filter is active #18179

Fix backend articles manager not listing articles in sub-categories when categories filter is active #18179

Conversation

ggppdk commented Oct 1, 2017 • edited by infograf768

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

alikon commented Oct 1, 2017

degobbis commented Oct 1, 2017

ggppdk commented Oct 1, 2017 • edited

degobbis commented Oct 1, 2017

alikon commented Oct 1, 2017

ggppdk commented Oct 1, 2017 • edited

ggppdk commented Oct 1, 2017

alikon commented Oct 1, 2017

brianteeman commented Oct 1, 2017

alikon commented Oct 1, 2017

ggppdk commented Oct 1, 2017 • edited

infograf768 commented Oct 2, 2017

Bakual commented Oct 2, 2017 • edited

degobbis commented Oct 2, 2017

hrefferh commented Oct 2, 2017

pickeboe commented Oct 2, 2017

ggppdk commented Oct 2, 2017

Quy Oct 2, 2017

Choose a reason for hiding this comment

ggppdk Oct 2, 2017

Choose a reason for hiding this comment

Quy Oct 2, 2017 • edited

Choose a reason for hiding this comment

ggppdk Oct 2, 2017 • edited

Choose a reason for hiding this comment

infograf768 commented Oct 2, 2017 • edited

ggppdk commented Oct 2, 2017

hrefferh commented Oct 3, 2017

ggppdk commented Oct 3, 2017 • edited

infograf768 commented Oct 3, 2017

ggppdk commented Oct 3, 2017 • edited

ggppdk commented Oct 3, 2017

hrefferh commented Oct 3, 2017 • edited

ggppdk commented Oct 3, 2017

ggppdk commented Oct 3, 2017

ggppdk commented Oct 3, 2017

hrefferh commented Oct 3, 2017

ghost commented Oct 3, 2017

infograf768 commented Oct 4, 2017

infograf768 commented Oct 4, 2017

mbabker Oct 5, 2017

Choose a reason for hiding this comment

ggppdk Oct 5, 2017

Choose a reason for hiding this comment

infograf768 commented Oct 8, 2017

bobr666 commented Nov 30, 2017

zero-24 commented Nov 30, 2017

sandstorm871 commented Mar 28, 2018

ggppdk commented Mar 28, 2018 • edited

sandstorm871 commented Mar 28, 2018

ggppdk commented Oct 1, 2017 •

edited by infograf768

ggppdk commented Oct 1, 2017 •

edited

ggppdk commented Oct 1, 2017 •

edited

ggppdk commented Oct 1, 2017 •

edited

Bakual commented Oct 2, 2017 •

edited

Quy Oct 2, 2017 •

edited

ggppdk Oct 2, 2017 •

edited

infograf768 commented Oct 2, 2017 •

edited

ggppdk commented Oct 3, 2017 •

edited

ggppdk commented Oct 3, 2017 •

edited

hrefferh commented Oct 3, 2017 •

edited

ggppdk commented Mar 28, 2018 •

edited