Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix users custom fields data lost when reset password #18188

Closed
wants to merge 1 commit into from
Closed

Fix users custom fields data lost when reset password #18188

wants to merge 1 commit into from

Conversation

joomdonation
Copy link
Contributor

@joomdonation joomdonation commented Oct 2, 2017

Pull Request for Issue # .

Summary of Changes

This PR fixes users custom fields data lost when reset password. See #18185 for issue description

Testing Instructions

  1. Follow the issue Custom Fields get reset to default after changig password #18185, confirm the issue
  2. Apply patch, try to reset password again, make sure users custom fields data is not lost anymore
  3. Try to edit an user account from backend, make sure custom fields data still being saved properly

@Trossler
Copy link

Trossler commented Oct 2, 2017

tested ... running
it works
thx

@wojsmol
Copy link
Contributor

wojsmol commented Oct 3, 2017

@Trossler Please mark your test result on https://issues.joomla.org/tracker/joomla-cms/18188.

@ghost
Copy link

ghost commented Oct 3, 2017

altered Test of @Trossler at Issue Tracker.

@laoneo
Copy link
Member

laoneo commented Oct 3, 2017

This pr doesn't solve the root of the issue. There is a general problem when the save functions are triggered without the custom fields (and any extension which injects data into a form). I tried to solve it in #17837. Because I think we should solve the root issue. Would be good if you can test #17837 as well as this should solve the root of the problem.

@joomdonation
Copy link
Contributor Author

@laoneo I will look at your PR and test it later today after work.

@laoneo
Copy link
Member

laoneo commented Oct 3, 2017

Thanks. I guess we have here a similar problem to #17801.

@joomdonation
Copy link
Contributor Author

Yes, you're right. That's why I think that we are doing in wrong way (posted it here #18185 (comment) , too).

@Trossler
Copy link

Trossler commented Oct 3, 2017

it is not necessarily the way of the problem I think also. @laoneo @joomdonation

on my current page has been a huge problem with it.
300 members - almost daily was changed a member the password so also the profile fields data - deleted.
there was trouble with the members ... so your help was really great

@ghost
Copy link

ghost commented Oct 26, 2017

@joomdonation @laoneo how to go on with this Pull request?

@laoneo
Copy link
Member

laoneo commented Oct 26, 2017

I would go with #17837 as it fixes the root cause of the issue.

@ghost
Copy link

ghost commented Oct 26, 2017

Thanks @laoneo. If this Issue get no other Response, it will be closed at 26th November 2017.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants