New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Content - Contact plugin #18258
Conversation
This works fine but needs some code improvements.
To get: remark that we use JNO and JYES, therefore the strings
should be taken off the ini file. Also the fields name do usually use lowercase characters. Also I would change Also use lowercase for html tags in text strings, i.e. not |
@infograf768 the > needs to be indented like this
|
Should the version number also be upgraded? I have another doubt: in the xml the "extension version" is set to 3.2, but in php code the "protected $db;" code says it's available since 3.3... |
No need to touch the versions. |
I have tested this item This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18258. |
I have tested this item This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18258. |
RTC after two successful tests. |
@mbabker Please decide a milestone for this. |
plugins/content/contact/contact.xml
Outdated
description="PLG_CONTENT_CONTACT_PARAM_URL_DESCRIPTION" | ||
default="0" | ||
> | ||
<option value="0">PLG_CONTENT_CONTACT_PARAM_URL_0</option> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of 0/1/2 for the option values can we use text names so it's clear what each of these options are (so url/webpage/email).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve string changes
Summary of Changes
Currently Content - Contact plugin can only link the author name to the internal page of the contact associated to the author of the article.
This PR enhances the plugin with the ability to choose the webpage or the email of the associated contact as link to the author.
An option is added if the admin doesn't want to apply links to the real author when an alias name is used as article author.
Testing Instructions
Enable "Show author" and "Link author" in global article options, or just in one article; enable Content - Contact plugin; associate a contact to the user who created the article.
Expected result
When the article is displayed, the author name will be linked to the internal contact page (this is the default and it works like before).
You can change the type of link in the plugin configuration: "website" will link the author name to the website specified in the contact details (if any); "email" will open the default email client to email to the address provided in contact details.
Actual result
Only the link to the internal contact page is available.