Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors _quickicons.less #18278

Merged
merged 3 commits into from Oct 8, 2017
Merged

Conversation

ciar4n
Copy link
Contributor

@ciar4n ciar4n commented Oct 8, 2017

Pull Request for Issue # .

Summary of Changes

Refactors the admin templates _quickicons.less

Testing Instructions

Apply PR and ensure the quickicons display correctly. No changes in styling so they should appear as before.

image

@ghost
Copy link

ghost commented Oct 8, 2017

I have tested this item ✅ successfully on 23486bd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18278.

margin: 12px 0 5px;
font-size: 13px;
&:first-child {
margin: 0px 0 5px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove px from 0px

@ciar4n
Copy link
Contributor Author

ciar4n commented Oct 8, 2017

@Quy Ty... amended.

@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on 002b90b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18278.

@dgrammatiko
Copy link
Contributor

RTC

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 8, 2017
@wilsonge wilsonge merged commit 117202d into joomla:staging Oct 8, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 8, 2017
@wilsonge wilsonge modified the milestones: Joomla 3.9.0, Joomla 3.8.2 Oct 8, 2017
@ciar4n ciar4n deleted the quickicons-refactor branch October 8, 2017 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants