New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Search Module does not display in the error.php page #18375
Conversation
But what changes in the core have made this problem as this has worked for years. Surely that is the "bug" to find and fix. This is just a band aid to mask the "bug" |
This PR is now only for beez3 and protostar templates. [UPDATED] By replacing |
The As for |
The part with removing |
I want to say that if the module will be disabled/removed then it will still be displayed on error page. |
Well, this very easily balloons into a bigger patch. Because:
For that first part, what we do in the For what this is right now, it's fine I would say. |
I have tested this item ✅ successfully on b691428 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18375. |
1 similar comment
I have tested this item ✅ successfully on b691428 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18375. |
RTC after two successful tests. |
Testing Instructions
Display the error page with Protostar or Beez with a link like
mydomain.com/whatever
Expected result
The search module should display
Actual result
It does not not display
Patch and test again
You should get for Protostar
and for Beez