[com_fields] Multilanguage: fixing display of fields when the item concerned is set to ALL #18536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concerned is set to ALL
|
This PR does not solve yet the filtering of User custom fields (profile) as discussed in #18474 (comment) |
|
I have tested this item ✅ successfully on 28d5132 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18536. |
|
@ajejebrazorf01 can you please test? |
|
I have tested this item ✅ successfully on 28d5132 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18536. |
|
RTC after two successful tests. |
|
@laoneo Free to all to propose a better solution, if it exists. |
|
I can have a look on JWC. |
|
Can you make a pr with the proper testing instructions, I can't reproduce it. Probably I do something wrong. |
Will do. |
laoneo
approved these changes
Nov 20, 2017
joomla-cms-bot
added
PR-staging
and removed
RTC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #18396 , replaces #18474
Issue: An item (article in that case) tagged to ALL languages is displaying all fields tagged to specific languages.
Summary of Changes
When an item is tagged to ALL languages, only display custom fields tagged to ALL languages as well as custom fields tagged to the Active language.
Testing Instructions
Create a multilingual site. 2 Content languages are enough. Here for en-GB and fr-FR
Structure:
===>Categories
===>Articles set as Featured
===> Home menu as Featured Articles menu item for each language.
===> Create some articles custom fields and assign languages, including ALL
Expected result
Example for articles for a multingual site with 2 Content Languages:
For an article tagged to ALL, only custom fields tagged to ALL as well as custom fields tagged to the Active language should display.
This to follow the current behavior of any item on a multilang site: items set to ALL display whatever the language, items set to a specific language only display when the language is the active one.
Actual result
Custom fields tagged to ALL as well as custom fields tagged to any Content Language are displayed
Before patch
French
English
After Patch
French
English
@laoneo
@AlexRed
@ajejebrazorf01
@ggppdk