[com_fields] Handle tag items properly

[laoneo]

Pull Request for Issue #18992.

Summary of Changes

Prepares an item in the tags view with the custom fields. It mapps the tag context to the propper one of the item which has the tag.

Testing Instructions

• Create an article custom field.
• Create an article with a value of the custom field and give it a tag.
• Create a menu item "Tagged Items" and select the tag you gave the article, also set "Item Description" to Show as on the screenshot below
  
• Open the menu on the front

Expected result

The custom fields are shown on the item.

Actual result

No custom fields are shown.

[ghost]

@shionphan can you please test?

[ghost]

I have tested this item 🔴 unsuccessfully on 6056d1d

Field (Type: Text, using Default Settings) isn't shown applied PR.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19006.}

[laoneo]

@franz-wohlkoenig what shows up on the front? Did you not set a value ion the article for the custom field?

[ghost]

In Frontend nothing new (=Field-Value) is shown. Value in Field is set.

[laoneo]

Can you post a screenshot of your page? Are you sure you took the right menu item type?

[ghost]

You see a little more Space between Title and Text using PR.

Without PR

With PR

[laoneo]

What's in the space, when you inspect it with the developer tools of your browser?

[ghost]

[laoneo]

So a field is loaded which means it works. It can be an override or another patch installed which interferes on your site. Lets see if others have the same behavior.

[ghost]

If other have not same Behaviour i install new one.

[esedic]

I also can't get custom fields to display.

<dl class="fields-container"></dl>

is created but it's empty.

[ghost]

Same Behaviour on clean Install.

[shionphan]

@franz-wohlkoenig @laoneo

I have test code <?php echo $item->event->beforeDisplayContent; ?> successfull.
It seems great. Thanks all.

Screenshot was script console.log

Issue

Some fields can not display.

Others fields what be set default value could be displaed.

Possible Causes

Find code $fields = FieldsHelper::getFields($context, $item, true); in /plugins/system/fields/fields.php

Add console code

$console = json_encode($fields);
echo ('<script>console.log(' . $console . ')</script>');

Some field value In article page will be displayed, But it dose not display in com_tags page.

[ghost]

@shionphan please mark your Test as successfully:

• open Issue Tracker
• Login with your github-Account
• Click on blue "Test this"-Button above Authors-Picture
• mark your Test as successfully
• hit "submit test result"

[laoneo]

Just tested it and the custom fields values are shown as expected.

Can you guys exactly describe what for steps you did where the field is not displayed. It would be helpfull if you can test with the latest staging code and from a fresh joomla installation.

[ghost]

System information

3.8.3-rc
Multilanguage Site (4 Lang.) & Sample Data
macOS Sierra, 10.12.6
Firefox 57 (64-bit)

MAMP 4.2

• PHP 7.0.22
• MySQLi 5.6.35

Create new Field

Article: Value on Field and Tag

Menu "Tags » Tagged Items" using Tag and Item Description to show

Result:

[laoneo]

Are you testing it with the latest staging?

[ghost]

I test on 3.8.3-rc, former Test nightly Builds.

[shionphan]

Tested successfull that if I install a new Joomla clean package, but it dose not work on my site.
I will rebuild database for continue to follow up.

[laoneo]

@shionphan please fill the test instructions from Franz to mark the pr as a successful test. Thanks.

[shionphan]

I have tested this item ✅ successfully on 6056d1d

Tested successfull that if I install a new Joomla clean package

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19006.}

[shionphan]

@laoneo Sorry for the work too busy.
A new problem you have to know. Tags page will display items fields when i add new items. However, the old item data will not be displayed.

We know that fields data is different from items data in mysql (table name is ##_contentitem_tag_map.content_item_id). I can guarantee that I add the data operation is the same.

Solution

Line 423 (Your post)

$item->id       = $item->content_id;

Change into:

$item->id       = $item->content_item_id;

Demo pages

https://www.infinisign.com/products/all-type/multi-domain (Chinese Language)

[laoneo]

@shionphan thanks for the hint, changed it. Can you guys please retest if it is working now as expected?

[ghost]

I have tested this item ✅ successfully on f440255

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19006.}

[shionphan]

I have tested this item ✅ successfully on f440255

Perfect

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19006.}

[ghost]

Ready to Commit after two successful tests.