[4.0] Fix missing filters (com_menus & com_associations)

[C-Lodder]

Pull Request for Issue #18815

Summary of Changes

Fix the filters

Testing Instructions

• Go to administrator/index.php?option=com_menus&view=menus
• You should see a filter to switch between Site and Administrator

---

• Go to administrator/index.php?option=com_menus&view=items
• You should see a filter to switch between Site and Administrator
• You should see a filter to select the menu type

---

• Go to administrator/index.php?option=com_associations
• You should see a filter to for Item type and Language

[infograf768]

This works great. Can you please also change the lang constant which has nothing to do here:
<joomla-alert type="warning"><?php echo JText::_('COM_LANGUAGES_MULTILANGSTATUS_NONE'); ?></joomla-alert>
to
<joomla-alert type="warning"><?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS'); ?></joomla-alert>
in com_menus/tmpl/items/default.php and in com_menus/tmpl/items/modal

EDIT: no use. Will correct with new PR including some other stuff

[ghost]

I have tested this item ✅ successfully on c1edfed

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19044.}

[infograf768]

@C-Lodder
I will correct the code to use the new attribute, and at the same time take off that wrong constant.
Therefore, let's merge this as I will have to modify the same file.

[infograf768]

I have tested this item ✅ successfully on c1edfed

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19044.}

[infograf768]

rtc

@wilsonge Please merge asap to let me make new PR

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19044.}

[infograf768]

Thanks @wilsonge
@C-Lodder
We are having some discussions about this new noresults attribute in the maintainers chat.
Shall we keep it or not is the question.

[C-Lodder]

I don't mind whether it's kept or not. I'm just a UI dev

[infograf768]

You can see what we can get if we keep the attribute in 4.0
For com_associations, com_content (articles and Featured), com_categories, com_associations.
noresults.diff.zip

For com_associations, one has also to delete in its custom searchtools layout the bar.php