[a11y & c/s] Module settings #19128
Merged
[a11y & c/s] Module settings #19128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 31ec569 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19128. |
1 similar comment
|
I have tested this item ✅ successfully on 31ec569 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19128. |
|
Ready to Commit after two successful tests. |
joomla-cms-bot
added
PR-staging
and removed
RTC
photodude
pushed a commit
to photodude/joomla-cms
that referenced
this pull request
Dec 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add
aria-hidden="true"and semicolon.Testing Instructions
Code review
and/or
Log to the front end.
Edit a module.
Use web inspector on
Save,Save & Close, andClosebuttons.Expected result
Actual result
<span class="icon-apply"></span>Documentation Changes Required
none