Change error on registration #19142
Merged
Change error on registration #19142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the admin if a registration fails then it is an error message but on the front end it was only a warning This PR makes them both errors PR for joomla#9502
|
I still get the warning message and not error message. |
|
The code Brian modified is for error when activating account. For registration failed error messages, you will need to modify code in different places: https://github.com/joomla/joomla-cms/blob/staging/components/com_users/controllers/registration.php#L150 |
|
Will look again later |
|
Updated - thanks for testing |
|
I have tested this item ✅ successfully on dd887b3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19142. |
1 similar comment
|
I have tested this item ✅ successfully on dd887b3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19142. |
|
Ready to Commit after two successful tests. |
|
Thanks |
photodude
pushed a commit
to photodude/joomla-cms
that referenced
this pull request
Dec 25, 2017
* Change error on registration In the admin if a registration fails then it is an error message but on the front end it was only a warning This PR makes them both errors PR for joomla#9502 * all validation errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the admin if a registration fails then it is an error message but on the front end it was only a warning
This PR makes them both errors
PR for #9502