Clean up ContentViewCategory #19237
Closed
Clean up ContentViewCategory #19237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
Jan 1, 2018
| @@ -79,7 +81,8 @@ public function display($tpl = null) | |||
| $numLinks = $params->def('num_links', 4); | |||
| $this->vote = JPluginHelper::isEnabled('content', 'vote'); | |||
|
|
|||
| JPluginHelper::importPlugin('content'); | |||
| PluginHelper::importPlugin('content'); | |||
There was a problem hiding this comment.
Line 82 has a prefix J. This one does not. Should they be the same and with or without J?
|
I have tested this item ✅ successfully on 02f1b74 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19237. |
|
Ouch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This PR makes some clean up to ContentViewCategory classes:
Use namespace classes instead of it's alias
Move $dispatcher = JEventDispatcher::getInstance(); out of the loop, so we get a bit performance improvement
Remove code to set view layout as it is set on parent class code already https://github.com/joomla/joomla-cms/blob/staging/libraries/src/MVC/View/CategoryView.php#L212-L223
Remove some un-used variables (like $id, $pathway), reuse-existing variable (no need for $menu = $menu->getActive() when we have $active variable keep active menu item before)
Testing Instructions
Code review should be enough. For human testing, please create a menu item to display articles from a category (Category Blog layout menu option for example), check and make sure articles still being displayed like before