New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Fix wrong ConfigModel class #19380
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
changed the title
Fix wrong ConfigModel class
[4.0] Fix wrong ConfigModel class
Jan 15, 2018
@bembelimen is there an open Issue reported for broken model class? |
Hi,
Is there one required?
…-------- Ursprüngliche Nachricht --------Von: Franz Wohlkönig <notifications@github.com> Datum: 15.01.18 08:01 (GMT+01:00) An: joomla/joomla-cms <joomla-cms@noreply.github.com> Cc: Benjamin Trenkle <bembelimen@web.de>, Mention <mention@noreply.github.com> Betreff: Re: [joomla/joomla-cms] [4.0] Fix wrong ConfigModel class (#19380)
@bembelimen is there an open Issue reported for broken model class?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/joomla/joomla-cms","title":"joomla/joomla-cms","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/joomla/joomla-cms"}},"updates":{"snippets":[{"icon":"PERSON","message":"@franz-wohlkoenig in #19380: @bembelimen is there an open Issue reported for broken model class?"}],"action":{"name":"View Pull Request","url":"#19380 (comment)"}}}
|
not required. I asked to close Issue if its open. |
I don't know, I did not create one. |
Thanks for Info, will search for an open Issue. |
@bembelimen can you please have a Look at #17812 #8582 if both report other Issue? |
Yep, that are other issues |
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR fixs the broken model class
Testing Instructions
Submit an article over the frontend while you're a non-Super User and have the message plugin active
Expected result
Article saved, email sent
Actual result
Exception, because the model class is wrong.