Implement initial port support for PostgreSQL driver

[zero-24]

Pull Request for Issue #18578 cc: @irbian

Summary of Changes

Add the port option to the PostgreSQL driver

Testing Instructions

Steps to reproduce the issue

Have a connection on a port different than the default and try to make a query on it

        $options = array();
        
        $options['driver']   = 'postgresql';        
        $options['host']     = '192.192.192.192';
        $options['port'] = '15432'; 
        $options['user']     = 'myuser';       
        $options['password'] = 'mypassword'; 
        $options['database'] = 'MYDATABASE';
        $options['prefix']   = '';             
        
        $dbo =  JDatabaseDriver::getInstance( $options );

Expected result

I expect to work

Actual result

"Error connecting to PGSQL database."

Open Points

• Do we need want this kind of port detection: https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/database/driver/mysqli.php#L105-L154 like we have it for mysql?

[mbabker]

FWIW the Framework handled this a bit differently, see joomla/joomla-framework#141 for the PR adding it (implementation is basically still the same now).

And no, I don't think you need the same type of detection as the MySQLi driver. That honestly seems really verbose for reasons I don't understand without getting into the commit logs.

[zero-24]

Thanks @mbabker i have just implemented the port detection from the framework! @irbian please feel free to test this one.

[Quy]

You can do explode(':', $this->options['host']). Then $tmp[0] will be the domain and $tmp[1] will be the port if provided.

[zero-24]

I have used the code from here: https://github.com/joomla-framework/database/blob/master/src/Postgresql/PostgresqlDriver.php so i think we should fix it in the source first can you send a PR with the needed changes?

[csthomas]

I'm not sure but if you always adding port=... then you will always force connection by TCP/IP and remove option to connect by unix socket, which usual faster.

[zero-24]

Ok i'm going to move the port setting up to the host so if the host is not set we try without host &port for a socket Connection

[zero-24]

Sorry took longer than expected but it is done now :)

[zero-24]

What is holding us back from testing and merging this thing or should this just be closed as the interest is gone?

[mbabker]

What is holding us back from testing and merging this thing

Finding the 3 people who actually use Joomla with PostgreSQL support and getting their feedback?

[alikon]

i've tested successully on not default port like 5444

[alikon]

I have tested this item ✅ successfully on de3d104

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19466.}

[twister65]

I can not find a port number field in the System -> Global configuration -> Server -> Database Settings form.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19466.}

[Quy]

@twister65 You can append the port to the Host eg. 192.192.192.192:15432

[twister65]

I have tested this item ✅ successfully on 2111f2f

Tested successfully with port 5466 and postgresql driver (as well as the already implemented port with pgsql PDO driver).

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19466.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19466.}