Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix for Bug after creating an override #19482

Merged
merged 1 commit into from
Jan 30, 2018

Conversation

astridx
Copy link
Contributor

@astridx astridx commented Jan 29, 2018

Pull Request for Issue # #19475

Summary of Changes

Set UA User agent to 'Joomla'

Testing Instructions

  1. Open Extensions->Templates-> Create overrides.
  2. Try any option Module, Component, Layout.
    -> an error will occur.
  3. Apply this patch and open Extensions->Templates-> Create overrides.
  4. Try any option Module, Component, Layout.
    -> override is created.

Expected result

Creates an override of the extension (folder+files)

Actual result

Getting this error :
0 Argument 1 passed to Joomla\CMS\Version::getUserAgent() must be of the type string, null given, called in libraries/src/Factory.php on line 758

Folder is created, no files.

Documentation Changes Required

No

@ghost
Copy link

ghost commented Jan 30, 2018

I have tested this item ✅ successfully on a80cc0e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19482.

1 similar comment
@ghazal
Copy link
Contributor

ghazal commented Jan 30, 2018

I have tested this item ✅ successfully on a80cc0e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19482.

@ghost
Copy link

ghost commented Jan 30, 2018

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 30, 2018
@wilsonge wilsonge merged commit f431605 into joomla:4.0-dev Jan 30, 2018
@wilsonge
Copy link
Contributor

Thanks :)

@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Jan 30, 2018
@zero-24 zero-24 added this to the Joomla 4.0 milestone Feb 2, 2018
@astridx astridx deleted the j4_template_error_in_override branch August 9, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants