[com_content] - Add tags filtering based on language filter#19509
Merged
mbabker merged 4 commits intojoomla:3.9-devfrom May 28, 2018
alikon:patch-69
Merged
[com_content] - Add tags filtering based on language filter#19509mbabker merged 4 commits intojoomla:3.9-devfrom alikon:patch-69
mbabker merged 4 commits intojoomla:3.9-devfrom
alikon:patch-69
Conversation
|
@csbalazs please mark your Test as successfully:
|
|
I have tested this item ✅ successfully on 16830cf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19509. After the repairs: |
Quy
reviewed
Feb 1, 2018
| $listDirn = $this->escape($this->state->get('list.direction')); | ||
| $langFilter = false; | ||
|
|
||
| //Tags filtering based on language filter |
Quy
reviewed
Feb 1, 2018
| $langFilter = ComponentHelper::getParams('com_tags')->get('tag_list_language_filter'); | ||
| } | ||
| } | ||
|
|
|
I have tested this item ✅ successfully on c82a894 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19509. |
Quy
reviewed
Feb 1, 2018
| break; | ||
|
|
||
| default : | ||
| $langFilter = ComponentHelper::getParams('com_tags')->get('tag_list_language_filter'); |
Contributor
There was a problem hiding this comment.
Change to $langFilter = $tagfilter;
Contributor
|
I have tested this item ✅ successfully on 3cc5970 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19509. |
1 similar comment
|
I have tested this item ✅ successfully on 3cc5970 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19509. |
|
Ready to Commit after two successful tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #19387 .
Summary of Changes
Testing Instructions
Expected result
The category list tag filter works as expected
Actual result