New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[com_content] - Add tags filtering based on language filter #19509
Conversation
@csbalazs please mark your Test as successfully:
|
I have tested this item ✅ successfully on 16830cf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19509. After the repairs: |
$listDirn = $this->escape($this->state->get('list.direction')); | ||
$langFilter = false; | ||
|
||
//Tags filtering based on language filter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add space after //
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
$langFilter = ComponentHelper::getParams('com_tags')->get('tag_list_language_filter'); | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete blank line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
I have tested this item ✅ successfully on c82a894 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19509. |
break; | ||
|
||
default : | ||
$langFilter = ComponentHelper::getParams('com_tags')->get('tag_list_language_filter'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to $langFilter = $tagfilter;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
I have tested this item ✅ successfully on 3cc5970 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19509. |
1 similar comment
I have tested this item ✅ successfully on 3cc5970 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19509. |
Ready to Commit after two successful tests. |
Pull Request for Issue #19387 .
Summary of Changes
Testing Instructions
Expected result
The category list tag filter works as expected
Actual result