Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_content] - Add tags filtering based on language filter #19509

Merged
merged 4 commits into from May 28, 2018

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Feb 1, 2018

Pull Request for Issue #19387 .

Summary of Changes

  • unpublished tags are now not returned
  • tags are returned based on Language Filter option setting

Testing Instructions

  • create some tags in different languages and set some to unpublished status
  • create a Category List menu item and set Filter Field to Tags

Expected result

The category list tag filter works as expected

Actual result

  • tags are showed even if they are unpublished
  • tags are showed in all languages always
@ghost
Copy link

@ghost ghost commented Feb 1, 2018

@csbalazs please mark your Test as successfully:

  • open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as successfully
  • hit "submit test result"
@csbalazs
Copy link

@csbalazs csbalazs commented Feb 1, 2018

I have tested this item successfully on 16830cf

It works now! Thx!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19509.

After the repairs:
Site language: Hungarian, The tag filter only shows Hungarian tags.
1802011
Site language: English, The tag filter only shows English tags.
1802012

$listDirn = $this->escape($this->state->get('list.direction'));
$langFilter = false;

//Tags filtering based on language filter

This comment has been minimized.

@Quy

Quy Feb 1, 2018
Contributor

Add space after //

This comment has been minimized.

@alikon

alikon Feb 1, 2018
Author Contributor

done

$langFilter = ComponentHelper::getParams('com_tags')->get('tag_list_language_filter');
}
}

This comment has been minimized.

@Quy

Quy Feb 1, 2018
Contributor

Delete blank line.

This comment has been minimized.

@alikon

alikon Feb 1, 2018
Author Contributor

done

cs
@csbalazs
Copy link

@csbalazs csbalazs commented Feb 1, 2018

I have tested this item successfully on c82a894


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19509.

break;

default :
$langFilter = ComponentHelper::getParams('com_tags')->get('tag_list_language_filter');

This comment has been minimized.

@Quy

Quy Feb 1, 2018
Contributor

Change to $langFilter = $tagfilter;

This comment has been minimized.

@alikon

alikon Feb 1, 2018
Author Contributor

yes

@Quy
Copy link
Contributor

@Quy Quy commented Feb 1, 2018

I have tested this item successfully on 3cc5970


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19509.

1 similar comment
@csbalazs
Copy link

@csbalazs csbalazs commented Feb 2, 2018

I have tested this item successfully on 3cc5970


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19509.

@ghost
Copy link

@ghost ghost commented Feb 2, 2018

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label Feb 2, 2018
@mbabker mbabker added this to the Joomla 3.9.0 milestone Feb 13, 2018
@mbabker mbabker changed the base branch from staging to 3.9-dev May 28, 2018
@mbabker mbabker added PR-3.9-dev and removed PR-staging labels May 28, 2018
@mbabker mbabker modified the milestones: Joomla 3.10.0, Joomla 3.9.0 May 28, 2018
Michael Babker
@mbabker mbabker merged commit 96b0e1b into joomla:3.9-dev May 28, 2018
1 of 4 checks passed
1 of 4 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/drone/pr this build is pending
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Hound No violations found. Woof!
@joomla-cms-bot joomla-cms-bot removed the RTC label May 28, 2018
@alikon alikon deleted the alikon:patch-69 branch May 30, 2018
@joomla joomla deleted a comment Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.