[4.0] Namespace content site route helper #19870
Conversation
|
Conflicts. But I want to sit on this one for a bit. I really really don't like mapping this class globally. But I need to have a think about what a better solution actually looks like - presumably something in the extensions container? :/ |
|
I was also thinking about the container. Problem is that mostly legacy code is using it where boot is not called before. |
…ntent/route # Conflicts: # administrator/components/com_content/tmpl/articles/modal.php # components/com_contact/tmpl/contact/default_articles.php # components/com_content/Dispatcher/Dispatcher.php # components/com_content/Helper/AssociationHelper.php # components/com_content/View/Article/HtmlView.php # components/com_content/tmpl/article/default.php
|
Conflicts fixed |
ghost
added
the
|
@wilsonge can you have a second look on this one. People are asking why we still have lowercase folders in core with classes. And on this one there is no reason to not namespace it. |
|
Thanks! |
|
I still feel that this is wrong because 3PD extensions have no way of adding entries into the extensions mapper file. This file should be something that we use to allow other extensions to function who extended non-namespaced classes. But as you say it gets the namespacing done for now and can be improved in the future. |
|
Can you create an issue with your comments so it doesn't get forgotten |
|
Done |
Summary of Changes
Namespace content site route helper.
Testing Instructions
Open an article on the front.
Expected result
Article is displayed.
Actual result
Article is displayed.