Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#32033] Removing MooTools dependencies from overrider.js #2001

Closed
wants to merge 4 commits into from
Closed

[#32033] Removing MooTools dependencies from overrider.js #2001

wants to merge 4 commits into from

Conversation

AshanFernando
Copy link
Contributor

Under GSoC MooTools to jQuery project, this PR removes the MooTools dependencies in media/overrider/js/overrider.js file.

Feature Tracker Item:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32033&start=550

@mbabker
Copy link
Contributor

mbabker commented Mar 26, 2014

This pull too? Also, the .map file won't be necessary anymore as we've updated to jQuery 1.11.

@roland-d
Copy link
Contributor

Is this still valid?
You may blame the J!Tracker Application for transmitting this comment.

@AshanFernando
Copy link
Contributor Author

@mbabker Did you find any need for modifications?

@mbabker
Copy link
Contributor

mbabker commented Aug 16, 2014

Aside from needing synchronized to the current HEAD and removing the .map file, I think this is OK. But I don't quite remember my notes from 5 months ago that well anymore ;-)

@roland-d
Copy link
Contributor

I have created a new PR against staging #4128.

@Bakual
Copy link
Contributor

Bakual commented Aug 18, 2014

Closing in favor of #4128

@Bakual Bakual closed this Aug 18, 2014
@brianteeman brianteeman reopened this Sep 2, 2014
@AshanFernando AshanFernando changed the title Removing MooTools dependencies from overrider.js [#32033] Removing MooTools dependencies from overrider.js Sep 2, 2014
@infograf768
Copy link
Member

Brian, #4128 has been merged into 3.4
we do not need this one anymore. Closing..

@infograf768 infograf768 closed this Sep 2, 2014
@brianteeman
Copy link
Contributor

I am just gardening not reading every word

On 2 September 2014 09:46, infograf768 notifications@github.com wrote:

Brian, #4218 has been merged into 3.4
we do not need this one anymore. Closing..


Reply to this email directly or view it on GitHub
#2001 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants