New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#32034] Removing MooTools dependencies from beez3 template #2002
[#32034] Removing MooTools dependencies from beez3 template #2002
Conversation
Todo: hide.js (templates/beez3/javascript/hide.js)
There are +2 tests, so i think it can be merged. |
Test info from JoomlaCode: Removing MooTools dependencies from templates/beez3/ folder by converting it to jQuery and JavaScript. Test: Applied patch, enabled Beez3, site appears to work fine in regular & mobile resolutions. |
Could you please update your branch to the latest version of staging and you will encounter a few issues regarding codestyle, afaics. If that part is done, I think this can be merged directly. It's actually a shame that this has not been merged earlier... |
@hackwa Ok will do... ! Thanks for notifying |
…usertemplates Conflicts: templates/beez3/javascript/hide.js
@test After resolving the conflicts, tested this on Chrome (Mobile mode with Nexus 5) using the breez3 template and simulated menu open and close which worked as expected. |
@test OK, in desktop and mobile (Tested creating weblink) This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2002. |
@AshanFernando I can't apply this patch in git. Sorry to be a pain but would you please resubmit it against the current staging branch and I'll straight merge it with the tests from there as long as all the commits are the same :) |
@wilsonge Done :) |
that is the wrong project... |
you need to apply that against joomla/joomla-cms and the staging branch. |
Thanks Ashan! Closing this one in favour of the new one! |
Under GSoC MooTools to jQuery project, this PR removes the MooTools dependencies in beez3 template folder
Feature Tracker Item:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32034&start=575