Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#32034] Removing MooTools dependencies from beez3 template #2002

Closed
wants to merge 6 commits into from
Closed

[#32034] Removing MooTools dependencies from beez3 template #2002

wants to merge 6 commits into from

Conversation

AshanFernando
Copy link
Contributor

Under GSoC MooTools to jQuery project, this PR removes the MooTools dependencies in beez3 template folder

Feature Tracker Item:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32034&start=575

@810
Copy link
Contributor

810 commented Dec 20, 2013

There are +2 tests, so i think it can be merged.

@RCheesley
Copy link

Test info from JoomlaCode:

Removing MooTools dependencies from templates/beez3/ folder by converting it to jQuery and JavaScript.
Branch: https://github.com/AshanFernando/joomla-cms/tree/gsoc-mootools-jquery-usertemplates
Pull Request: #2002

Test:
Go to Extensions->Template Manager from administrator section. Change default Site template to Beez3. The site template should work for mobile size views(Menu Item Change) and other functionalities should work without errors.

Applied patch, enabled Beez3, site appears to work fine in regular & mobile resolutions.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2002.

@Hackwar
Copy link
Member

Hackwar commented Nov 17, 2014

Could you please update your branch to the latest version of staging and you will encounter a few issues regarding codestyle, afaics. If that part is done, I think this can be merged directly. It's actually a shame that this has not been merged earlier...

@AshanFernando
Copy link
Contributor Author

@hackwa Ok will do... ! Thanks for notifying

…usertemplates

Conflicts:
	templates/beez3/javascript/hide.js
@AshanFernando AshanFernando changed the title Removing MooTools dependencies from beez3 template [#32034] Removing MooTools dependencies from beez3 template Nov 18, 2014
@AshanFernando
Copy link
Contributor Author

@test After resolving the conflicts, tested this on Chrome (Mobile mode with Nexus 5) using the breez3 template and simulated menu open and close which worked as expected.

@anibalsanchez
Copy link
Contributor

@test OK, in desktop and mobile (Tested creating weblink)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2002.

@wilsonge
Copy link
Contributor

@AshanFernando I can't apply this patch in git. Sorry to be a pain but would you please resubmit it against the current staging branch and I'll straight merge it with the tests from there as long as all the commits are the same :)

@AshanFernando
Copy link
Contributor Author

@Hackwar
Copy link
Member

Hackwar commented Dec 27, 2014

that is the wrong project...

@Hackwar
Copy link
Member

Hackwar commented Dec 27, 2014

you need to apply that against joomla/joomla-cms and the staging branch.

@AshanFernando
Copy link
Contributor Author

@Hackwar Thanks for the correction.. I have created a new PR
#5543

@wilsonge
Copy link
Contributor

Thanks Ashan! Closing this one in favour of the new one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants