New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mod_articles_news] Option Intro/Full Images of the article #20169

Merged
merged 14 commits into from May 28, 2018

Conversation

Projects
None yet
8 participants
@carlitorweb
Contributor

carlitorweb commented Apr 14, 2018

Pull Request for Issue #19599 , #16495

Summary of Changes

Option to use or not, the intro image field or the full image field of the article

Testing Instructions

  1. Go to Extensions ->Modules and create a new Articles - Newsflash
  2. Put Show Images option, for any of the 3 options that list. Also, configure the module to display correctly in some position of the template
  3. Go to Content -> Articles, and use in one of the articles that the module will show, any of the fields "Intro image" or "Full article image"
  4. Go to the frontend, and check depending on the option that you put in the module, it shows or not, the image correctly

Expected result

The module shows or not, the fields "Intro image" or "Full article image" of the article correctly

Actual result

The current option only display images in the article context.

Documentation Changes Required

New module option added.

[mod_articles_news] Option Intro/Full Images of the article
Option to use or not, the intro image field or the full image field of
the article
@carlitorweb

This comment has been minimized.

Show comment
Hide comment
@carlitorweb

carlitorweb Apr 14, 2018

Contributor

Is done, thank you @Quy

Contributor

carlitorweb commented Apr 14, 2018

Is done, thank you @Quy

carlitorweb added some commits Apr 14, 2018

Code review
Fixed default attribute of the image field inside the xml file.
Added a condition in case the caption of the image is empty, for no show
unnecessarily the figcaption tag
@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Apr 15, 2018

I have tested this item successfully on a3b2f08


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

franz-wohlkoenig commented Apr 15, 2018

I have tested this item successfully on a3b2f08


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

@bubi-luka

This comment has been minimized.

Show comment
Hide comment
@bubi-luka

bubi-luka Apr 15, 2018

I have tested this item successfully on a3b2f08


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

bubi-luka commented Apr 15, 2018

I have tested this item successfully on a3b2f08


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Apr 15, 2018

Ready to Commit after two successful tests.

franz-wohlkoenig commented Apr 15, 2018

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label Apr 15, 2018

@carlitorweb

This comment has been minimized.

Show comment
Hide comment
@carlitorweb

carlitorweb Apr 15, 2018

Contributor

Thank you again @Quy . I need have more careful with this small things.

Contributor

carlitorweb commented Apr 15, 2018

Thank you again @Quy . I need have more careful with this small things.

@ReLater

This comment has been minimized.

Show comment
Hide comment
@ReLater

ReLater Apr 19, 2018

Contributor

I have tested this item successfully on 68e2e54


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

Contributor

ReLater commented Apr 19, 2018

I have tested this item successfully on 68e2e54


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

@carlitorweb carlitorweb requested a review from brianteeman as a code owner Apr 20, 2018

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Apr 20, 2018

Contributor

"Display article intro or full image."
==>
"Display article, intro or full image."

Contributor

brianteeman commented on language/en-GB/en-GB.mod_articles_news.ini in 7d388c0 Apr 20, 2018

"Display article intro or full image."
==>
"Display article, intro or full image."

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Apr 20, 2018

Contributor

"Show Intro-Full Image"
==>
"Show Intro/Full Image"

Contributor

brianteeman commented on language/en-GB/en-GB.mod_articles_news.ini in 7d388c0 Apr 20, 2018

"Show Intro-Full Image"
==>
"Show Intro/Full Image"

@carlitorweb

This comment has been minimized.

Show comment
Hide comment
@carlitorweb

carlitorweb Apr 24, 2018

Contributor

Ok done. Hope is better now.

Contributor

carlitorweb commented Apr 24, 2018

Ok done. Hope is better now.

@ReLater

This comment has been minimized.

Show comment
Hide comment
@ReLater

ReLater Apr 24, 2018

Contributor

I have tested this item successfully on 5efd862


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

Contributor

ReLater commented Apr 24, 2018

I have tested this item successfully on 5efd862


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

@Quy

This comment has been minimized.

Show comment
Hide comment
@Quy

Quy Apr 24, 2018

Contributor

I have tested this item successfully on 5efd862


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

Contributor

Quy commented Apr 24, 2018

I have tested this item successfully on 5efd862


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

@Quy

This comment has been minimized.

Show comment
Hide comment
@Quy

Quy Apr 24, 2018

Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

Contributor

Quy commented Apr 24, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

@joomla-cms-bot joomla-cms-bot added the RTC label Apr 24, 2018

@mbabker mbabker added this to the Joomla 3.9.0 milestone Apr 29, 2018

@mbabker mbabker changed the base branch from staging to 3.9-dev May 28, 2018

@mbabker mbabker added PR-3.9-dev and removed PR-staging labels May 28, 2018

@mbabker mbabker modified the milestones: Joomla 3.10.0, Joomla 3.9.0 May 28, 2018

@mbabker mbabker merged commit a7571f4 into joomla:3.9-dev May 28, 2018

5 checks passed

Hound No violations found. Woof!
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot removed the RTC label May 28, 2018

@carlitorweb carlitorweb deleted the carlitorweb:mod_article_news_img_option branch Jun 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment