[mod_articles_news] Option Intro/Full Images of the article #20169

carlitorweb · 2018-04-14T17:44:25Z

Pull Request for Issue #19599 , #16495

Summary of Changes

Option to use or not, the intro image field or the full image field of the article

Testing Instructions

Go to Extensions ->Modules and create a new Articles - Newsflash
Put Show Images option, for any of the 3 options that list. Also, configure the module to display correctly in some position of the template
Go to Content -> Articles, and use in one of the articles that the module will show, any of the fields "Intro image" or "Full article image"
Go to the frontend, and check depending on the option that you put in the module, it shows or not, the image correctly

Expected result

The module shows or not, the fields "Intro image" or "Full article image" of the article correctly

Actual result

The current option only display images in the article context.

Documentation Changes Required

New module option added.

Option to use or not, the intro image field or the full image field of the article

Quy · 2018-04-14T18:38:36Z

modules/mod_articles_news/helper.php

+				{
+					$item->imageSrc = htmlspecialchars($images->image_intro, ENT_COMPAT, 'UTF-8');
+					$item->imageAlt = htmlspecialchars($images->image_intro_alt, ENT_COMPAT, 'UTF-8');
+					if ($images->image_intro_caption) 


Add blank line above.

Quy · 2018-04-14T18:38:45Z

modules/mod_articles_news/helper.php

+				{
+					$item->imageSrc = htmlspecialchars($images->image_fulltext, ENT_COMPAT, 'UTF-8');
+					$item->imageAlt = htmlspecialchars($images->image_fulltext_alt, ENT_COMPAT, 'UTF-8');
+					if ($images->image_intro_caption) 


Add blank line above.

Quy · 2018-04-14T18:39:48Z

modules/mod_articles_news/helper.php

+						$item->imageCaption = htmlspecialchars($images->image_intro_caption, ENT_COMPAT, 'UTF-8');
+					}					
+				}				
+				else if ($params->get('image') == "full" && isset($images->image_fulltext) && !empty($images->image_fulltext))


Change to elseif. Change " to '. Change == to ===.

Quy · 2018-04-14T18:40:05Z

modules/mod_articles_news/helper.php

 			{
-				$item->introtext = preg_replace('/<img[^>]*>/', '', $item->introtext);
+				$images = json_decode($item->images);
+				$item->imageSrc = "";


Change "" to ''

Quy · 2018-04-14T18:41:02Z

modules/mod_articles_news/helper.php

@@ -119,9 +119,32 @@ public static function getList(&$params)

 			$item->introtext = JHtml::_('content.prepare', $item->introtext, '', 'mod_articles_news.content');

-			if (!$params->get('image'))
+			// Get the data of the image, if it is going to be shown
+			if ($params->get('image') != "none")


Change " to '

Quy · 2018-04-14T18:41:10Z

modules/mod_articles_news/helper.php

+				$item->imageSrc = "";
+				$item->imageAlt = "";
+				$item->imageCaption = "";
+				if ($params->get('image') == "intro" && isset($images->image_intro) && !empty($images->image_intro))


Change " to '. Change == to ===.

Quy · 2018-04-14T18:42:50Z

modules/mod_articles_news/helper.php

+					{
+						$item->imageCaption = htmlspecialchars($images->image_fulltext_caption, ENT_COMPAT, 'UTF-8');
+					}
+


Remove blank line.

Quy · 2018-04-14T18:43:44Z

modules/mod_articles_news/mod_articles_news.xml

 					label="MOD_ARTICLES_NEWS_FIELD_IMAGES_LABEL"
 					description="MOD_ARTICLES_NEWS_FIELD_IMAGES_DESC"
-					class="btn-group btn-group-yesno"
-					default="0"
+					default="1"


Was a mistake. Now is okay

Quy · 2018-04-14T18:45:42Z

language/en-GB/en-GB.mod_articles_news.ini

@@ -30,6 +30,8 @@ MOD_ARTICLES_NEWS_FIELD_TRIGGEREVENTS_DESC="Triggers additional plugin events to
 MOD_ARTICLES_NEWS_FIELD_TRIGGEREVENTS_LABEL="Trigger Plugin Events"
 MOD_ARTICLES_NEWS_FIELD_SHOWINTROTEXT_DESC="Show or hide the article intro text."
 MOD_ARTICLES_NEWS_FIELD_SHOWINTROTEXT_LABEL="Show Intro Text"
+MOD_ARTICLES_NEWS_OPTION_INTROIMAGE="Intro image"


Change to Image

Quy · 2018-04-14T18:46:30Z

modules/mod_articles_news/tmpl/_item.php

+	<figure class="newsflash-image">
+		<img src="<?php echo $item->imageSrc;?>" alt="<?php echo $item->imageAlt;?>">
+		<figcaption>
+			<?php echo $item->imageCaption;?>


Add space after ;

Quy · 2018-04-14T18:46:39Z

modules/mod_articles_news/tmpl/_item.php

@@ -22,6 +22,15 @@
 	</<?php echo $item_heading; ?>>
 <?php endif; ?>

+<?php if ($params->get('image') != "none" && !empty($item->imageSrc)) : ?>	
+	<figure class="newsflash-image">
+		<img src="<?php echo $item->imageSrc;?>" alt="<?php echo $item->imageAlt;?>">


Add space after ;

Quy · 2018-04-14T18:46:55Z

modules/mod_articles_news/tmpl/_item.php

@@ -22,6 +22,15 @@
 	</<?php echo $item_heading; ?>>
 <?php endif; ?>

+<?php if ($params->get('image') != "none" && !empty($item->imageSrc)) : ?>	


Change " to '

carlitorweb · 2018-04-14T20:26:37Z

Is done, thank you @Quy

Fixed default attribute of the image field inside the xml file. Added a condition in case the caption of the image is empty, for no show unnecessarily the figcaption tag

ghost · 2018-04-15T06:11:51Z

I have tested this item ✅ successfully on a3b2f08

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.}

bubi-luka · 2018-04-15T08:57:57Z

I have tested this item ✅ successfully on a3b2f08

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.}

ghost · 2018-04-15T09:06:54Z

Ready to Commit after two successful tests.

Quy · 2018-04-15T11:14:31Z

modules/mod_articles_news/helper.php

+				$item->imageSrc = '';
+				$item->imageAlt = '';
+				$item->imageCaption = '';
+				if ($params->get('image') === 'intro' && isset($images->image_intro) && !empty($images->image_intro))


Add blank line above.

Quy · 2018-04-15T11:14:55Z

modules/mod_articles_news/tmpl/_item.php

+<?php if ($params->get('image') != 'none' && !empty($item->imageSrc)) : ?>	
+	<figure class="newsflash-image">
+		<img src="<?php echo $item->imageSrc; ?>" alt="<?php echo $item->imageAlt; ?>">
+		<?php if(!empty($item->imageCaption)) : ?>


Add space after if

Quy · 2018-04-15T11:15:59Z

modules/mod_articles_news/mod_articles_news.xml

-					<option value="0">JNO</option>
+					<option value="intro">MOD_ARTICLES_NEWS_OPTION_INTROIMAGE</option> 
+					<option value="full">MOD_ARTICLES_NEWS_OPTION_FULLIMAGE</option>
+					<option value="null">JNO</option>


Change to none?

carlitorweb · 2018-04-15T13:28:45Z

Thank you again @Quy . I need have more careful with this small things.

ReLater · 2018-04-19T14:26:06Z

I have tested this item ✅ successfully on 68e2e54

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.}

ReLater · 2018-04-20T14:58:56Z

language/en-GB/en-GB.mod_articles_news.ini

@@ -7,8 +7,8 @@ MOD_ARTICLES_NEWS="Articles - Newsflash"
 MOD_ARTICLES_NEWS_FIELD_FEATURED_DESC="Show or hide articles marked as featured."
 MOD_ARTICLES_NEWS_FIELD_FEATURED_LABEL="Featured Articles"
 MOD_ARTICLES_NEWS_FIELD_CATEGORY_DESC="Select Articles from a specific Category or a set of Categories. If no selection will show all categories as default."
-MOD_ARTICLES_NEWS_FIELD_IMAGES_ARTICLE_DESC="Display article intro or full image."
-MOD_ARTICLES_NEWS_FIELD_IMAGES_ARTICLE_LABEL="Show Intro-Full Image"
+MOD_ARTICLES_NEWS_FIELD_IMAGES_ARTICLE_DESC="Display article, intro or full image."


@brianteeman help pls.
I don't think that the comma is correct here. The string should describe something like:
"Show the intro image or the full image that you selected in the article"
but not
"Show article image or the intro image or the full image"

(for the images inside article text we have another setting)

sorry I thought it was display article or intro or full
in this context the word article is not needed and as you can see fro my error it can be misleading
i dont think we ever refer to them as article images any way so
why not simply say
Display the intro or full image

I wrote the "article" word, trying not to confuse the one who reads it, with the other param. "Intro image" and "Full image", are well known, but include the "article" word, I think it locates better which fields we're talking about.

Somehow or other but the comma is wrong. I myself would prefer a description without "article" here. For me an "article" image (inside the editor text) is distinct from an "intro" image is distinct from a "full" image. The description would be clearer for me as a not native English speaker.

carlitorweb · 2018-04-24T19:16:30Z

Ok done. Hope is better now.

ReLater · 2018-04-24T20:45:32Z

I have tested this item ✅ successfully on 5efd862

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.}

Quy · 2018-04-24T21:24:44Z

I have tested this item ✅ successfully on 5efd862

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.}

Quy · 2018-04-24T21:24:53Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.}

ute-sch · 2019-05-13T14:14:57Z

Please help (my Joomla's up to date):
The Article-Newsflash Module doesn't show the Intro or Full image, as offered in the field.

What I found out - sorry, I'm not a programmer:

In the options field there's an english-german language mixup - see the screenshot:
http://www.schultz-hamburg.de/joomla-newsflash.png
Doesn't the module find the appropriate value?
I couldn't find the file where the values are translated and assigned to the corresponding keys.

I only found the german translation file de-DE_mod_articles-news_ini where the following lines are missing:
MOD_ARTICLES_NEWS_FIELD_IMAGES_ARTICLE_DESC="... german translation ..." MOD_ARTICLES_NEWS_FIELD_IMAGES_ARTICLE_LABEL="... german translation ..."
This is not a big issue, it's only the translation of the label and the description - so I tried and added it on my site. Of course, it didn't help with the bug.

Thanks for your patience!

ghost · 2019-05-13T14:16:37Z

@ute-sch please ask on Forum

[mod_articles_news] Option Intro/Full Images of the article

374f0d1

Option to use or not, the intro image field or the full image field of the article

joomla-cms-bot added Language Change This is for Translators PR-staging labels Apr 14, 2018

This was referenced Apr 14, 2018

Module News has no option for inserting intro image #19599

Closed

[mod_newsflash] Tooltip Display Article Images is unclear #16495

Closed

Quy reviewed Apr 14, 2018

View reviewed changes

carlitorweb added 2 commits April 14, 2018 16:26

Code review

b3e9dfb

Fixed default attribute of the image field inside the xml file. Added a condition in case the caption of the image is empty, for no show unnecessarily the figcaption tag

Code review

a3b2f08

bubi-luka approved these changes Apr 15, 2018

View reviewed changes

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 15, 2018

Quy reviewed Apr 15, 2018

View reviewed changes

Code review

2f36afe

Change old string for better descriptive label

68e2e54

carlitorweb requested a review from brianteeman as a code owner April 20, 2018 09:33

carlitorweb added 2 commits April 20, 2018 05:35

Trying better label/desc string

7d388c0

Code review

b0c7f9c

brianteeman approved these changes Apr 20, 2018

View reviewed changes

ReLater reviewed Apr 20, 2018

View reviewed changes

Code review

5efd862

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 24, 2018

mbabker added this to the Joomla 3.9.0 milestone Apr 29, 2018

brianteeman modified the milestones: Joomla 3.9.0, Joomla 3.10.0 May 8, 2018

mbabker changed the base branch from staging to 3.9-dev May 28, 2018 14:58

mbabker added PR-3.9-dev and removed PR-staging labels May 28, 2018

mbabker modified the milestones: Joomla 3.10.0, Joomla 3.9.0 May 28, 2018

mbabker merged commit a7571f4 into joomla:3.9-dev May 28, 2018

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 28, 2018

zero-24 mentioned this pull request Jun 3, 2018

[3.9] [mod_articles_news] Option Intro/Full Images of the article joomlagerman/joomla#425

Closed

SharkyKZ mentioned this pull request Jun 20, 2018

Article News Flash module doesn't show images #20803

Closed

carlitorweb deleted the mod_article_news_img_option branch June 20, 2018 12:13

ReLater mentioned this pull request Aug 10, 2018

[4.0] Newsflash image parameter doesn't display Intro images #21546

Closed

ciar4n mentioned this pull request Oct 18, 2018

[4.0] [mod_article_news] No output for image #22698

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[mod_articles_news] Option Intro/Full Images of the article #20169

[mod_articles_news] Option Intro/Full Images of the article #20169

carlitorweb commented Apr 14, 2018 •

edited

Quy Apr 14, 2018

Quy Apr 14, 2018

Quy Apr 14, 2018 •

edited

Quy Apr 14, 2018 •

edited

Quy Apr 14, 2018

Quy Apr 14, 2018 •

edited

Quy Apr 14, 2018

Quy Apr 14, 2018

carlitorweb Apr 14, 2018

Quy Apr 14, 2018

Quy Apr 14, 2018

Quy Apr 14, 2018

Quy Apr 14, 2018

carlitorweb commented Apr 14, 2018

ghost commented Apr 15, 2018

bubi-luka commented Apr 15, 2018

ghost commented Apr 15, 2018

Quy Apr 15, 2018

Quy Apr 15, 2018

Quy Apr 15, 2018

carlitorweb commented Apr 15, 2018

ReLater commented Apr 19, 2018

ReLater Apr 20, 2018

brianteeman Apr 20, 2018

carlitorweb Apr 20, 2018

ReLater Apr 23, 2018

carlitorweb commented Apr 24, 2018

ReLater commented Apr 24, 2018

Quy commented Apr 24, 2018

Quy commented Apr 24, 2018

ute-sch commented May 13, 2019

ghost commented May 13, 2019

[mod_articles_news] Option Intro/Full Images of the article #20169

[mod_articles_news] Option Intro/Full Images of the article #20169

Conversation

carlitorweb commented Apr 14, 2018 • edited

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Quy Apr 14, 2018 • edited

Choose a reason for hiding this comment

Quy Apr 14, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Quy Apr 14, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlitorweb commented Apr 14, 2018

ghost commented Apr 15, 2018

bubi-luka commented Apr 15, 2018

ghost commented Apr 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlitorweb commented Apr 15, 2018

ReLater commented Apr 19, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlitorweb commented Apr 24, 2018

ReLater commented Apr 24, 2018

Quy commented Apr 24, 2018

Quy commented Apr 24, 2018

ute-sch commented May 13, 2019

ghost commented May 13, 2019

carlitorweb commented Apr 14, 2018 •

edited

Quy Apr 14, 2018 •

edited

Quy Apr 14, 2018 •

edited

Quy Apr 14, 2018 •

edited