Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Hard Coupling (com_users | plg_users_joomla) #20275
Fixed Hard Coupling (com_users | plg_users_joomla) #20275
Changes from 20 commits
28edf5c
1c056ec
ab35379
239a5fd
74b96eb
7c05d6c
feec4ba
7ee9641
327ec06
3a5b6e3
86ee607
5f504cc
8cad84d
f4f3704
040a7ac
ae8fe3a
9e333a9
7a16367
3bd5533
420d6e4
ec4581c
fe03395
d7a60f9
b633bbf
bf9ec93
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really shouldn't make a reference to a specific line number in a code comment. If the code's updated, this reference goes away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is true, thank you @mbabker my mistake, sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first comment should also be updated.
$data
is an empty array on save. After returning from error,$data
is an array but populated.@mbabker can you comment on form data issue?
FormController
does not load form data by default, making it unavailable inonContentPrepareForm
when saving. Code based onForm::getValue()
also fails. Is this correct behavior? Should we use data from input instead?