Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[com_contenthistory] - fix for not delete keep forever items #20430

Merged
merged 4 commits into from
Jun 18, 2018
Merged

[com_contenthistory] - fix for not delete keep forever items #20430

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c196e3
[com_contenthistory] - fix for not delete kepp forever items
alikon May 16, 2018
67fd1e4
don't stop delete
alikon May 16, 2018
21d6933
cs
alikon May 16, 2018
8bcc229
cs removed spaces at end of line
Jun 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions administrator/components/com_contenthistory/models/history.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,15 @@ public function delete(&$pks)
// Iterate the items to delete each one.
foreach ($pks as $i => $pk)
{

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete blank line

if ($table->load($pk))
{
if ($table->keep_forever === "1")
{
unset($pks[$i]);
continue;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace at end of the line

}

if ($this->canEdit($table))
{
if (!$table->delete($pk))
Expand Down