Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Register the correct templates component class in the container #20649

Merged
merged 2 commits into from
Jun 3, 2018

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Jun 2, 2018

Pull Request for Issue #20645.

Summary of Changes

Registers the correct component class in the templates DI container.

Testing Instructions

Open Extensions -> Templates -> Templates.

Expected result

List of templates is shown.

Actual result

Error: JHtml templates not found.

@anuragteapot
Copy link
Contributor

Class TemplatesHelper not found

screenshot from 2018-06-02 22-10-28

Template manager not working properly.

@laoneo
Copy link
Member Author

laoneo commented Jun 2, 2018

@Anu1601CS can you try again? Fixed some helper includes.

@anuragteapot
Copy link
Contributor

I have tested this item ✅ successfully on 2b6673a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20649.

@wilsonge wilsonge merged commit c420982 into joomla:4.0-dev Jun 3, 2018
@wilsonge wilsonge deleted the j4/fix/templates/component branch June 3, 2018 09:11
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants