-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plg_user_profile] Add RTL check to ToS field #20894
Conversation
OK on review. |
I have tested this item ✅ successfully on b22e63b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20894. |
@infograf768 can you please mark your Test as successfully on Issue Tracker? |
@SharkyKZ
|
@infograf768 thanks for the tip. Removing CSS completely. No sense to have it here. |
Right, did not even test that before proposing the possible solution. 👍 |
I have tested this item ✅ successfully on 20eeef5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20894. |
1 similar comment
I have tested this item ✅ successfully on 20eeef5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20894. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20894. |
Pull Request for Issue # .
Summary of Changes
This adds RTL check to ToS field for popover positioning. Missed it in #20412.
Testing Instructions
Install and enable an RTL language. Enable the plugin and ToS field. Go to registration page and check that ToS field popover is positioned the same way as other popovers.
Expected result
Popover positioned correctly.
Actual result
Popover not positioned correctly.
Documentation Changes Required
No.