New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mod_articles_latest/news] Featured articles not shown #21336

Merged
merged 1 commit into from Aug 2, 2018

Conversation

Projects
None yet
8 participants
@SharkyKZ
Contributor

SharkyKZ commented Aug 1, 2018

Pull Request for Issue #21333.

Summary of Changes

This fixes a bug introduced in #20845 of featured articles not being shown.

Testing Instructions

Create mod_articles_news or mod_articles_latest module.
Set Featured Articles to Show.

Expected result

Both featured and not featured articles are shown.

Actual result

Only not featured articles are shown.

Documentation Changes Required

No.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Aug 1, 2018

I have tested this item successfully on 5c282db


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21336.

franz-wohlkoenig commented Aug 1, 2018

I have tested this item successfully on 5c282db


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21336.

@alikon

This comment has been minimized.

Show comment
Hide comment
@alikon

alikon Aug 1, 2018

Contributor

I have tested this item successfully on 5c282db


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21336.

Contributor

alikon commented Aug 1, 2018

I have tested this item successfully on 5c282db


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21336.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Aug 1, 2018

Ready to Commit after two successful tests.

franz-wohlkoenig commented Aug 1, 2018

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label Aug 1, 2018

@makermann

This comment has been minimized.

Show comment
Hide comment
@makermann

makermann Aug 1, 2018

Also successfully tested.

makermann commented Aug 1, 2018

Also successfully tested.

@Folamour

This comment has been minimized.

Show comment
Hide comment
@Folamour

Folamour Aug 1, 2018

please what fix should i ask to apply ?

thanks,

Folamour commented Aug 1, 2018

please what fix should i ask to apply ?

thanks,

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 Aug 1, 2018

Member

@Folamour
There are 2 files to replace:
modules/mod_articles_latest/helper.php
and
modules/mod_articles_news/helper.php

I have added these in a .zip with their respective folders
patches_featured_articles.zip

Member

infograf768 commented Aug 1, 2018

@Folamour
There are 2 files to replace:
modules/mod_articles_latest/helper.php
and
modules/mod_articles_news/helper.php

I have added these in a .zip with their respective folders
patches_featured_articles.zip

@Folamour

This comment has been minimized.

Show comment
Hide comment
@Folamour

Folamour Aug 1, 2018

THANKS a lot, my service provider not reply at this time, thanks you so much

guillaume,

Folamour commented Aug 1, 2018

THANKS a lot, my service provider not reply at this time, thanks you so much

guillaume,

@Folamour

This comment has been minimized.

Show comment
Hide comment
@Folamour

Folamour Aug 1, 2018

Hi infograph hope you are fine, sorry that dont fix the issue, the article displayed still date from march not july : (

take a look rigth pane, "derniers articles" https://www.crashdebug.fr

thanks

Folamour commented Aug 1, 2018

Hi infograph hope you are fine, sorry that dont fix the issue, the article displayed still date from march not july : (

take a look rigth pane, "derniers articles" https://www.crashdebug.fr

thanks

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 Aug 1, 2018

Member

I was not sure it would solve your specific issue as this patch deals with featured articles, not the date.

Member

infograf768 commented Aug 1, 2018

I was not sure it would solve your specific issue as this patch deals with featured articles, not the date.

@Folamour

This comment has been minimized.

Show comment
Hide comment
@Folamour

Folamour Aug 1, 2018

ok so the issue remain, the module last article, no more show last published articles, but article from march instead of july, (its not featured only its all latest articles)

Folamour commented Aug 1, 2018

ok so the issue remain, the module last article, no more show last published articles, but article from march instead of july, (its not featured only its all latest articles)

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Aug 1, 2018

can you please use the Forum?

franz-wohlkoenig commented Aug 1, 2018

can you please use the Forum?

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 Aug 1, 2018

Member

@franz-wohlkoenig
We may firs make sure the original issue is true or not.
I mean #21347

After all nobody tested and it may not be a duplicate.

Member

infograf768 commented Aug 1, 2018

@franz-wohlkoenig
We may firs make sure the original issue is true or not.
I mean #21347

After all nobody tested and it may not be a duplicate.

@Folamour

This comment has been minimized.

Show comment
Hide comment
@Folamour

Folamour Aug 1, 2018

ok updated on forum

Folamour commented Aug 1, 2018

ok updated on forum

@mbabker mbabker added this to the Joomla 3.8.12 milestone Aug 2, 2018

@mbabker mbabker merged commit 846d49d into joomla:staging Aug 2, 2018

5 checks passed

Hound No violations found. Woof!
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels Aug 2, 2018

@SharkyKZ SharkyKZ deleted the SharkyKZ:modArticlesFeatured branch Aug 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment