Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upcom_installer version compare for database schema fixed #2146
Conversation
This comment has been minimized.
This comment has been minimized.
sovainfo
commented on a07bea3
Oct 5, 2013
|
Why the change in functionality with schemaVersion? When it is different it should be an error. That means the condition should be != 0 |
This comment has been minimized.
This comment has been minimized.
|
If the version of the current schema is higher than the version of Joomla, it should in general be ok. The other way around is normally the problem. |
This comment has been minimized.
This comment has been minimized.
sovainfo
replied
Oct 5, 2013
|
It is not ok when there are structural differences. Old scripts can't deal with changed structure. |
This comment has been minimized.
This comment has been minimized.
mbabker
replied
Oct 5, 2013
|
If the schema version is higher than the reported Joomla version, the only way to get there is if the user downgraded the file structure without handling the database. It'll only be an issue with having a newer database schema if there are fields that are NOT NULL with no defaults. Either way, using a version_compare statement is more correct than what's in place now. |
This comment has been minimized.
This comment has been minimized.
sovainfo
replied
Oct 5, 2013
|
Just as !=0 is more correct than == -1 !!! |
This comment has been minimized.
This comment has been minimized.
|
I'll fix it. :-) |
This comment has been minimized.
This comment has been minimized.
|
So these two are still open? No wonder people get missing update notices... Could we please merge this? Thanks. |
This comment has been minimized.
This comment has been minimized.
|
Same message here as in the other PR: Not enough testers logged in the tracker. And the one test doesn't even say which PR got tested (2.5 or 3.2?). |
This comment has been minimized.
This comment has been minimized.
|
Please redo towards staging (2.5.x one now merged). Thanks |
mbabker
closed this
in
b382d19
Feb 17, 2014
This comment has been minimized.
This comment has been minimized.
|
Merged manually to staging. |
Hackwar
referenced this pull request
Mar 6, 2014
Merged
Fixing version comparison for database schema #3249
added a commit
to Bakual/joomla-cms
that referenced
this pull request
May 12, 2014
Hackwar commentedOct 5, 2013
Here is the bug report: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32179
I don't know if this needs to be fixed in the fix() task of the installer, too.