com_installer version compare for database schema fixed

[Hackwar]

Here is the bug report: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32179

I don't know if this needs to be fixed in the fix() task of the installer, too.

[sovainfo]

Why the change in functionality with schemaVersion? When it is different it should be an error. That means the condition should be != 0

[Hackwar]

If the version of the current schema is higher than the version of Joomla, it should in general be ok. The other way around is normally the problem.

[sovainfo]

It is not ok when there are structural differences. Old scripts can't deal with changed structure.

[mbabker]

If the schema version is higher than the reported Joomla version, the only way to get there is if the user downgraded the file structure without handling the database. It'll only be an issue with having a newer database schema if there are fields that are NOT NULL with no defaults.

Either way, using a version_compare statement is more correct than what's in place now.

[sovainfo]

Just as !=0 is more correct than == -1 !!!

[Hackwar]

I'll fix it. :-)

[Hackwar]

So these two are still open? No wonder people get missing update notices... Could we please merge this? Thanks.

[Bakual]

Same message here as in the other PR: Not enough testers logged in the tracker. And the one test doesn't even say which PR got tested (2.5 or 3.2?).

[infograf768]

Please redo towards staging (2.5.x one now merged). Thanks

[mbabker]

Merged manually to staging.