com_installer version compare for database schema fixed #2146
Conversation
This comment has been minimized.
This comment has been minimized.
Why the change in functionality with schemaVersion? When it is different it should be an error. That means the condition should be != 0 |
This comment has been minimized.
This comment has been minimized.
If the version of the current schema is higher than the version of Joomla, it should in general be ok. The other way around is normally the problem. |
This comment has been minimized.
This comment has been minimized.
It is not ok when there are structural differences. Old scripts can't deal with changed structure. |
This comment has been minimized.
This comment has been minimized.
If the schema version is higher than the reported Joomla version, the only way to get there is if the user downgraded the file structure without handling the database. It'll only be an issue with having a newer database schema if there are fields that are NOT NULL with no defaults. Either way, using a version_compare statement is more correct than what's in place now. |
This comment has been minimized.
This comment has been minimized.
Just as !=0 is more correct than == -1 !!! |
This comment has been minimized.
This comment has been minimized.
I'll fix it. :-) |
So these two are still open? No wonder people get missing update notices... Could we please merge this? Thanks. |
Same message here as in the other PR: Not enough testers logged in the tracker. And the one test doesn't even say which PR got tested (2.5 or 3.2?). |
Please redo towards staging (2.5.x one now merged). Thanks |
Merged manually to staging. |
Here is the bug report: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32179
I don't know if this needs to be fixed in the fix() task of the installer, too.