[4.0] Table Column alignment (part 1) [a11y] #21933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
com_associations com_banners com_cache com_contacts com_content com_contenthistory The alignment of columns has changed since J3 and also doesn't match the design for j4. In addition text-center alignment is not good for accessibility, particularly dyslexi8a (word-blindness). https://www.w3.org/WAI/tutorials/tables/tips/ Alignment: Align text to the left and numeric data to the right (in left-to-right languages), so that people using larger text sizes or smaller screens will be able to find it. It’s helpful to give column headers the same alignment as the data in the cells below.
Quy
reviewed
Aug 31, 2018
|
Thanks! |
|
thanks - only another 60 files to go |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Aug 31, 2018
com_fields com_csp com_installer Continuation of joomla#21933
This was referenced Aug 31, 2018
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Sep 5, 2018
com_fields com_csp com_installer Continuation of joomla#21933 consistency wrap com-users com-templates com-tags com-plugins com-newsfeeds m3enus and modules Update default.php
wilsonge
pushed a commit
that referenced
this pull request
Sep 8, 2018
* [4.0] Table Column alignment (part2) [a11y] com_fields com_csp com_installer Continuation of #21933 * cs * consistency * wrap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
com_associations
com_banners
com_cache
com_contacts
com_content
com_contenthistory
The alignment of columns has changed since J3 and also doesn't match the design for j4. In addition text-center alignment is not good for accessibility, particularly dyslexi8a (word-blindness).
https://www.w3.org/WAI/tutorials/tables/tips/
Alignment: Align text to the left and numeric data to the right (in left-to-right languages), so that people using larger text sizes or smaller screens will be able to find it. It’s helpful to give column headers the same alignment as the data in the cells below.