[plugin][captcha] - not so invisible Captcha #21979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Already tested by @joeforjoomla here: #21974 (comment) |
|
Altered Test of @joeforjoomla This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21979. |
This was referenced Sep 7, 2018
Closed
|
I have tested this item ✅ successfully on 4334a00 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21979. |
|
I have tested this item ✅ successfully on 4334a00 Error message disappears. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21979. |
joomla-cms-bot
changed the title
|
Ready to Commit after two successful tests. |
roland-d
reviewed
Sep 8, 2018
| @@ -116,6 +116,7 @@ public function setup(\SimpleXMLElement $element, $value, $group = null) | |||
| if ($plugin === 0 || $plugin === '0' || $plugin === '' || $plugin === null) | |||
| { | |||
| $this->hidden = true; | |||
| return false; | |||
There was a problem hiding this comment.
Just a little nag, we need an empty line before the return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #21974 .
Summary of Changes
Testing Instructions
see #21974
Expected result
if no captcha enabled i can register without error msg/exception
Actual result
if no captcha enabled error msg/exception