[4.0] Finder: Replacing iconv() with mb_convert_encoding()

[Hackwar]

The original issue is this here: https://forum.joomla.org/viewtopic.php?t=860554#p3503601
Looking through the documentation, iconv() indeed has issues: https://secure.php.net/manual/en/function.iconv.php

The more reliable solution as it seems is this code.

Testing Instructions

Apply this patch and run the indexer of Smart Search in the backend. See that it still works.

[csthomas]

Similar solution is at:

joomla-cms/libraries/src/Filter/InputFilter.php

Lines 796 to 814 in eb68e01

	protected function remove($source)
	{
	// Check for invalid UTF-8 byte sequence
	if (!preg_match('//u', $source))
	{
	// String contains invalid byte sequence, remove it
	$source = htmlspecialchars_decode(htmlspecialchars($source, ENT_IGNORE, 'UTF-8'));
	}
	// Iteration provides nested tag protection
	do
	{
	$temp = $source;
	$source = $this->_cleanTags($source);
	}
	while ($temp !== $source);
	return $source;
	}

[laoneo]

The PHP mb extension is not always installed on hosts. So either way I would add a check or fallback to iconv if it is not available.

[mbabker]

symfony/polyfill-mbstring covers this if the extension isn't installed and it is already a transient dependency of 4.0 so this is fine as is.

[laoneo]

ok

[laoneo]

Thanks

[HLeithner]

ini_set returns the old value so this could be one operation

[HLeithner]

hmm ok commenting on an 5 year old pr makes no sense... sry for the noise