[4.0] Remove the deprecated code in the MultilangstatusHelper class #22301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
reviewed
Sep 23, 2018
| * | ||
| * @deprecated 4.0 Use Multilanguage::getSiteHomePages() instead. | ||
| */ | ||
| public static function getHomepages() |
There was a problem hiding this comment.
This is still being used by the com_languages admin view
wilsonge
approved these changes
Sep 23, 2018
|
Do we need to document deprecated code removal in core extensions? I would say that the API is enough. |
|
Yeah we don't need to document code removal in core extensions (we do need to note any architectural changes - but not function level changes like this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the deprecated code in the MultilangstatusHelper class.