New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compact image modal layout #22475
Compact image modal layout #22475
Conversation
<div class="span4 control-group"> | ||
<div class="pull-right"> | ||
<button class="btn btn-success button-save-selected" type="button" <?php if (!empty($onClick)) : | ||
// This is for Mootools compatibility ?>onclick="<?php echo $onClick; ?>"<?php endif; ?> data-dismiss="modal"><?php echo JText::_('COM_MEDIA_INSERT'); ?></button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent to match below?
Hopefully, you can come up with a fix for this related issue #17551. |
I will have a look. Better suited for a separate PR as it will likely touch all tiny mce modals. |
Toolbar is no longer pinned with this PR. |
Not sure if I understand. Would you have a screenshot? |
Strangely I am unable to replicate this issue. Toolbar is sticking in both Firefox and Chrome. |
Using your branch, it is not an issue. However, with beta4 and patchtester, then it is reproducible. |
An issue because of patchtester doesn't mean the patch has issues. It could very well be there is another change after beta 4 that patchtester isn't applying which is causing what you're seeing. It is literally impossible to make patchtester behave the same as if you're running |
I have tested this item ✅ successfully on ed85e70 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22475. |
@brianteeman Should be ok now. |
I have tested this item ✅ successfully on c2d7df2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22475. |
Tested again with I still have the same results as in #22475 (comment) |
I have tested this item ✅ successfully on 2f7270c System information
CloudAccess.net
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22475. |
I have tested this item ✅ successfully on 2f7270c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22475. |
Status "Ready To Commit". |
I don't think this can be RTC as @brianteeman is still seeing an issue |
@roland-d thanks, had only looked at number of tests. Status back on "Pending". |
@brianteeman Can you please test again? Tested fine on Windows 10: |
@roland-d We have 3 successful tests. I can't reproduce the issue Brian is having. Can we please merge it anyway? It is better than before and deal with the issue Brian has in a later PR if more people report it. |
@HLeithner As release leader, I will let you decide. |
It works for me fine in ff and vivaldi. I have have no idea why brian has this problem but I think its better to merge it then having the current state. thx |
Thanks all for the tests |
Pull Request for Issue # .
Summary of Changes
Compacts the media field modal layout and increases modal size. Removes the double scroll bar on larger screens. Currently, there are 3 options to close. This PR removes the close button in the footer (admin).
Testing Instructions
Apply PR and open administration media modal (media field -> select).
Before
After
Documentation Changes Required