[4.0] Installer library query fixes #22536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 5c873d7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22536. |
1 similar comment
|
I have tested this item ✅ successfully on 5c873d7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22536. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22536. |
joomla-cms-bot
added
PR-4.0-dev
and removed
RTC
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issues #21958 & #22531
Summary of Changes
As it seems nobody else will fix database query related issues, here's the pull request fixing two reported issues with queries in the extension installer library:
Testing Instructions
Expected result
Operations complete successfully
Actual result
Operations do not complete
Additional Comments
Any other style related fixes or errors are out of scope of this pull request and will not be addressed by me. Far too often unrelated fixes are being requested in pull requests making it easier for pull requests to introduce more changes and newer bugs, changes should be isolated and tested/reviewed separately.