Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_actionlogs] - log actionlog purge/export #22740

Merged
merged 19 commits into from Mar 7, 2019
Merged

[com_actionlogs] - log actionlog purge/export #22740

merged 19 commits into from Mar 7, 2019

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Oct 20, 2018

Pull Request for Issue #22695.

Summary of Changes

  • row/event is inserted/triggred after the purge
  • row/event is inserted/triggred after the export

Testing Instructions

Export/Purge the action logs
see #22695

Documentation Changes Required

@alikon alikon changed the title [com_actionlogs] - log actionlog purge [com_actionlogs] - log actionlog purge/export Oct 20, 2018
@PhilETaylor

This comment was marked as abuse.

Copy link
Contributor

@brianteeman brianteeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve language changes

brianteeman and others added 3 commits October 20, 2018 19:44
….php

Co-Authored-By: alikon <optimus4joomla@gmail.com>
@ReLater
Copy link
Contributor

ReLater commented Nov 6, 2018

I have tested this item 🔴 unsuccessfully on a4b8b28

Class 'Factory' not found
/administrator/components/com_actionlogs/models/actionlogs.php:300

Class 'Factory' not found
/administrator/components/com_actionlogs/models/actionlogs.php:323


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22740.

@alikon
Copy link
Contributor Author

alikon commented Nov 8, 2018

@ReLater please retest

@ReLater
Copy link
Contributor

ReLater commented Nov 8, 2018

I have tested this item ✅ successfully on 7f60480


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22740.

@PhilETaylor

This comment was marked as abuse.

@alikon
Copy link
Contributor Author

alikon commented Nov 8, 2018

the Factory::getApplication()->triggerEvent('onAfterLogPurge', array());

happens
😄

https://github.com/joomla/joomla-cms/pull/22740/files#diff-6d4ae54d455c6ccba7a75cc85b8bca19R301
https://github.com/joomla/joomla-cms/pull/22740/files#diff-6d4ae54d455c6ccba7a75cc85b8bca19R324

so no, no different messages are logged if you delete some or all

@PhilETaylor

This comment was marked as abuse.

@alikon
Copy link
Contributor Author

alikon commented Nov 8, 2018

feel free to submit the correct string, pr is open
english is not my best friend ;)

@PhilETaylor

This comment was marked as abuse.

@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on a9da4b8

I have tested this successfully on Joomla! 3.9.2.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22740.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on a9da4b8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22740.

@Quy
Copy link
Contributor

Quy commented Feb 3, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22740.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 3, 2019
@alikon alikon closed this Mar 7, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 7, 2019
@alikon alikon reopened this Mar 7, 2019
@HLeithner HLeithner merged commit 45a5c9d into joomla:staging Mar 7, 2019
@HLeithner
Copy link
Member

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet