Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_actionlogs] - log actionlog purge/export #22740

Merged
merged 19 commits into from Mar 7, 2019
Merged

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Oct 20, 2018

Pull Request for Issue #22695.

Summary of Changes

  • row/event is inserted/triggred after the purge
  • row/event is inserted/triggred after the export

Testing Instructions

Export/Purge the action logs
see #22695

Documentation Changes Required

@alikon alikon changed the title [com_actionlogs] - log actionlog purge [com_actionlogs] - log actionlog purge/export Oct 20, 2018
@PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented Oct 20, 2018

Does the export language need to reflect if EVERYTHING was exported, or if just a few rows were exported?

Copy link
Member

@brianteeman brianteeman left a comment

approve language changes

brianteeman and others added 3 commits Oct 20, 2018
….php

Co-Authored-By: alikon <optimus4joomla@gmail.com>
@ReLater
Copy link
Contributor

@ReLater ReLater commented Nov 6, 2018

I have tested this item 🔴 unsuccessfully on a4b8b28

Class 'Factory' not found
/administrator/components/com_actionlogs/models/actionlogs.php:300

Class 'Factory' not found
/administrator/components/com_actionlogs/models/actionlogs.php:323


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22740.

@alikon
Copy link
Contributor Author

@alikon alikon commented Nov 8, 2018

@ReLater please retest

@ReLater
Copy link
Contributor

@ReLater ReLater commented Nov 8, 2018

I have tested this item successfully on 7f60480


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22740.

@PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented Nov 8, 2018

Does the export language need to reflect if EVERYTHING was exported, or if just a few rows were exported?

What happens when a few rows are deleted? nothing? if we are rewriting history then that should be logged too right?

@alikon
Copy link
Contributor Author

@alikon alikon commented Nov 8, 2018

the Factory::getApplication()->triggerEvent('onAfterLogPurge', array());

happens
😄

https://github.com/joomla/joomla-cms/pull/22740/files#diff-6d4ae54d455c6ccba7a75cc85b8bca19R301
https://github.com/joomla/joomla-cms/pull/22740/files#diff-6d4ae54d455c6ccba7a75cc85b8bca19R324

so no, no different messages are logged if you delete some or all

@PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented Nov 8, 2018

so in that case saying

User {username} purged the action log

is actually factually incorrect and the language/terminology used needs to be changed - maybe something like

User {username} purged one or more rows from the action log

@alikon
Copy link
Contributor Author

@alikon alikon commented Nov 8, 2018

feel free to submit the correct string, pr is open
english is not my best friend ;)

@PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented Nov 8, 2018

As the only codeowner for language strings, the ultimate decision is with @brianteeman - he has already approved your language string even though it is factually incorrect.

I suggest he writes the factually correct sentence using his English skills.

@tecpromotion
Copy link
Contributor

@tecpromotion tecpromotion commented Jan 31, 2019

I have tested this item successfully on a9da4b8

I have tested this successfully on Joomla! 3.9.2.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22740.

@viocassel
Copy link
Contributor

@viocassel viocassel commented Feb 3, 2019

I have tested this item successfully on a9da4b8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22740.

@Quy
Copy link
Contributor

@Quy Quy commented Feb 3, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22740.

@alikon alikon closed this Mar 7, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC label Mar 7, 2019
@alikon alikon reopened this Mar 7, 2019
@HLeithner HLeithner merged commit 45a5c9d into joomla:staging Mar 7, 2019
3 checks passed
@HLeithner
Copy link
Member

@HLeithner HLeithner commented Mar 7, 2019

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet