Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Correcting Cassiopeia scss error #22831

Merged
merged 1 commit into from Oct 27, 2018

Conversation

infograf768
Copy link
Member

Pull Request for Issue #22830

Summary of Changes

$atum =>$cassiopeia

Testing Instructions

patch a clean checkout of the 4.0-dev branch
Run npm install

Expected result

Now the css files are created for cassiopeia

Can be merged on review (I guess)

@infograf768 infograf768 changed the title [4.0] Correcting Cassioeia scss error [4.0] Correcting Cassiopeia scss error Oct 27, 2018
@ghazal
Copy link
Contributor

ghazal commented Oct 27, 2018

I have tested this item ✅ successfully on a1a738b

I got all cassiopeia css files back but
I had to remove line 27 in /build/build-modules-js/update.js to allow
npm install
to work.

fsExtra.copySync(Path.join(rootPath, 'libraries/vendor/maximebf/debugbar/src/DebugBar/Resources'), Path.join(rootPath, 'media/vendor/debugbar'));

Not sure if it is the right way though.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22831.

@bembelimen
Copy link
Contributor

I have tested this item ✅ successfully on a1a738b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22831.

@infograf768
Copy link
Member Author

rtc. @wilsonge


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22831.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 27, 2018
@laoneo laoneo merged commit 06f5399 into joomla:4.0-dev Oct 27, 2018
@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Oct 27, 2018
@laoneo laoneo added this to the Joomla 4.0 milestone Oct 27, 2018
@Quy Quy mentioned this pull request Oct 27, 2018
@infograf768 infograf768 deleted the 4.0-cassiopeia_scss branch October 27, 2018 17:54
@Chacapamac
Copy link

How do I know when & where I apply the fix or update?

@ghazal
Copy link
Contributor

ghazal commented Oct 29, 2018

Check this:
J4.x:Setting Up Your Local Environment - Joomla! Documentation
https://docs.joomla.org/Special:MyLanguage/J4.x:Setting_Up_Your_Local_Environment
and this:
JavaScript Tests for Joomla4 - Joomla! Documentation
https://docs.joomla.org/JavaScript_Tests_for_Joomla4

Even though, in my opinion, these tuts should be revised.

@ghost
Copy link

ghost commented Oct 29, 2018

Even though, in my opinion, these tuts should be revised.

"Docs" is a Wiki, so anyone can contribute, revise ;-)

@ghazal
Copy link
Contributor

ghazal commented Oct 30, 2018

Yes. Indeed.
But my knowledge of CLI, NPM, Composer, etc ... is barely sufficient to get me through the procedure. I have more questions than answers.

@wilsonge
Copy link
Contributor

So what specific question do you have :) here to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants