[3.9][plg_user_terms] Add namespaces #22847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Septdir
changed the title
laoneo
approved these changes
Oct 29, 2018
Quy
reviewed
Oct 30, 2018
plugins/user/terms/field/terms.php
Outdated
| @@ -9,10 +9,14 @@ | |||
|
|
|||
| defined('JPATH_PLATFORM') or die; | |||
|
|
|||
| use Joomla\CMS\Form\FormHelper; | |||
There was a problem hiding this comment.
Please sort use statements in alpha order.
|
@Quy check Alpha order check please. |
|
I have tested this item ✅ successfully on 6c63500 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22847. |
1 similar comment
|
I have tested this item ✅ successfully on 6c63500 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22847. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22847. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first, I made PR by accident. I apologize for this. From now on I will be more attentive.
I decided that it would just be wrong to close and decided to add missing namespaces to User - Terms plugin.
Testing Instructions
Plugin should work correctly after applying this patch.