[3.9] Move confirm consent to use the bs modal vs mootools

[zero-24]

Partial Pull Request for Issue #22908

Summary of Changes

This replaces the Mootools modal vs a bootstrap modal

Testing Instructions

• Install 3.9.0
• enable the Content - ConfirmConsent Plugin
• configure this plugin to point to a article
• open a contact page on the website
• make sure the title is clickable and opens an modal
• apply this patch
• make sure it is still opening a modal this time it should be a bs modal

Expected result

bs modal

Actual result

mootools modal

Documentation Changes Required

none.

Additional Information

When this here gets approved & tested I can apply similar code to the other places where we use the old mootools modal:

• TOS Field:

  joomla-cms/plugins/user/profile/field/tos.php

  Line 83 in 9007811

  $attribs = array();

• Privacy Field:

  joomla-cms/plugins/system/privacyconsent/field/privacy.php

  Line 101 in 40dcca8

  $attribs = array();

• Terms Field:

  joomla-cms/plugins/user/terms/field/terms.php

  Line 101 in 40dcca8

  $attribs = array();

cc @brianteeman as he is the original author of the modal things in this plugin touched here.

[dgrammatiko]

@zero-24 please use a layout, do not do html markup inside the plugin!

[zero-24]

Can you please let me know what you want to change? As beyond the (already hardcoded) hight and width I did not add any extensive new HTML part in that plugin right? Or is there something special you want me to change?

[dgrammatiko]

There should be a tmpl folder with a layout (default.php or whatever) so people could actually do whatever they want in the front end, in other words, separate concerns. Check the https://github.com/joomla/joomla-cms/tree/staging/plugins/system/stats which was done correctly. This thing right now is hardcoded you cannot override anything unless you rewrite the whole plugin...

[Bakual]

While it is true that using a layout is better, this PR is valid by itself. Moving the thing to a layout can be done easily in a separate PR as well and is actually preferred. Since it makes the PRs more atomic and easier to test and review.

[SharkyKZ]

You can't output content here.

[SharkyKZ]

@zero-24 reminder, this needs to be fixed before merging. Can't output content in onContentPrepareForm().

[dgrammatiko]

While it is true that using a layout is better

I'll say that it's mandatory, not better. You're not in Joomla 1.5 designers and site builders need to have the ability to override the output without rewriting the plugin! My 2c anyways

[mbabker]

It should be a separate pull request for exactly the reasons @Bakual already stated. Nobody is saying not to move the code to layouts but when you start adding all sorts of extras onto pull requests they end up being too complex to properly test and review and people either ignore them or they end up getting merged while being completely broken.

[ReLater]

I have tested this item ✅ successfully on c7ac385

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22926.}

[drmenzelit]

I have tested this item ✅ successfully on c7ac385

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22926.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22926.}