Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix blog sampledata plugin #22937

Merged
merged 2 commits into from Nov 5, 2018
Merged

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Nov 4, 2018

Pull Request for Issue #22919

Summary of Changes

Telling the blog sampledata plugin to keep its mouth shut when it doesn't have anything to say.

Testing Instructions

Test that both the blog and the multilingual sampledata can be installed

Expected result

Both work

Actual result

Blog one works
Multilingual one stops after step 3

Documentation Changes Required

None

@Bakual Bakual changed the base branch from staging to 4.0-dev November 4, 2018 19:13
@Bakual Bakual changed the title Fix blog sampledata plugin [4.0] Fix blog sampledata plugin Nov 4, 2018
@laoneo laoneo removed the PR-staging label Nov 5, 2018
@infograf768
Copy link
Member

I have tested this item ✅ successfully on db4e3bb

It indeed solves installing multilingual sampledata.

Note: The success response is not displayed (step8)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22937.

@laoneo laoneo added this to the Joomla 4.0 milestone Nov 5, 2018
@laoneo laoneo merged commit aef1ed5 into joomla:4.0-dev Nov 5, 2018
@laoneo
Copy link
Member

laoneo commented Nov 5, 2018

Thanks

@Bakual Bakual deleted the FixBlogSampledataPlugin branch November 5, 2018 11:14
@zero-24 zero-24 removed their request for review November 5, 2018 13:32
@Chacapamac
Copy link

Sorry to ask but Newbie here, when you fix something like that, how do I fix my actual test site. Reinstall ?, Update? Not sure How ?

@Bakual
Copy link
Contributor Author

Bakual commented Nov 5, 2018

You wait for the next release (Joomla 3.9.1 4.0 Alpha 6 in that case) or apply the PR using the Patchtester (https://docs.joomla.org/Component_Patchtester_for_Testers).

@Chacapamac
Copy link

Thank’s Bakuai, I’m testing Joomla 4 alpha5-dev taken from —>
https://developer.joomla.org/nightly-builds.htm

And I add theCustom url —> https://update.joomla.org/core/nightlies/next_major_list.xml in my update options ?

@Bakual
Copy link
Contributor Author

Bakual commented Nov 5, 2018

4.0 is not for production yet at all. The upgrade option isn't guaranteed to work. So in this case, best bet would be to use the nightly builds and install fresh.

@Chacapamac
Copy link

No, it don’t seem to work, I try to reinstall the nighty builds, It didn’t work ....
— I See Thank

@Bakual
Copy link
Contributor Author

Bakual commented Nov 5, 2018

Nightly builds are generated nightly. This PR was merged only 4 hours ago. So you need at least wait till tomorrow till it will show up in the ngihtly 😄

@mbabker
Copy link
Contributor

mbabker commented Nov 5, 2018

Nightlies are on a cron job to be built at 02:00 UTC daily. So they truly are "nightly" builds and not continuously regenerated each time a commit is pushed to one of the active development branches.

@Chacapamac
Copy link

Thanks mbaker - Got it, I remark that the nighty build date is always today, I wasn’t so sure.
Great !

@Chacapamac
Copy link

Thanks Bakuai — Installing Now!
Now I just need to understand how can I help more and how to use this forum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants