Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Adding links to Modules in the System Panel #22957

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

infograf768
Copy link
Member

Pull Request for Issue #22950

Summary of Changes

As title says.
Links to site modules and admin modules are added in the Manage group

After patch

screen shot 2018-11-07 at 11 17 03

Note: the order of the new links in that group may be modified if desired.
Imho, the 3 languages links could be separated in a new group by itself as we do for templates.

@anibalsanchez
Copy link
Contributor

Looking goood!

Now, the question is: what is the order of the Manage items in the System Panel? (it's not alphabetic)

I would reorder them by the order of frequency of use. According to my experience, it should be:

  • Site Modules
  • Plugins
  • Extensions
  • Language(s)
  • Content Language(s)
  • Language Overrides
  • Content Security Policy
  • Redirects
  • Administrator Modules

@brianteeman
Copy link
Contributor

frequency is always subjective and personal

for users with cognitive disabilities it is important that they can easily find what they are looking for. A structured order helps here - often alphabetical

@ghazal
Copy link
Contributor

ghazal commented Nov 7, 2018

I have tested this item ✅ successfully on 275fd0f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22957.

@anibalsanchez
Copy link
Contributor

I have tested this item ✅ successfully on 275fd0f

Yes, sorting the items alphabetical is also a good solution.

Now, it looks like they are ordered by the date when they were added.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22957.

@infograf768
Copy link
Member Author

NOTE:
The items titles depend on the language. Therefore the alpha order in English will not be the same in another language.
This is solved in the Component menu as the submenus are alpha sorted
screen shot 2018-11-07 at 15 10 17
screen shot 2018-11-07 at 15 10 46

but can't be in this CPanel System view as the order depends on the order of the parts of code concerned.
Therefore, here, it always will be an arbitrary decision.
As I proposed above, creating a special group for Languages would reduce the size of this Manage group and make it faster to choose an item in the list.

@Bakual
Copy link
Contributor

Bakual commented Nov 7, 2018

As pointed out by JM, alphabetic ordering doesn't work here, and as Brian already said frequency doesn't work well as well.
I would go for a thematic order.
So language related things stay together. The two module links stay together. Those are no-brainers imho.

What I would further do is put the extension related things together. So extension first, then modules, plugins and language and then the various stuff (redirect, CSP). Then at least there is some logic in the ordering.
Something like this:

  • Extensions
  • Site Modules
  • Administrator Modules (or remove that and just do a "Modules" one)
  • Plugins
  • Language(s)
  • Content Language(s)
  • Language Overrides
  • Content Security Policy
  • Redirects

@anibalsanchez
Copy link
Contributor

@Bakual The problem of putting Extensions (or any of the other "optional" items) in the first place is that it is mostly used to Uninstall extensions. Meanwhile, Modules and Plugins are used every day to configure the site.

@mbabker
Copy link
Contributor

mbabker commented Nov 7, 2018

The sites I am working on consistently, the only screens I'm actively using from what is listed under the 3.x Extensions menu are the manage and update screens in com_installer (manage to turn off unused features after updates, and update for the obvious). There are sites I haven't changed a module or plugin in 2 years on aside from disabling them, so I would hardly call them items that are "used every day" or things that should be the first two items in a list.

So as was already said, those lists are going to be entirely subjective and "most frequently used based on my experience" is not an efficient means of trying to build a hardcoded list.

@Bakual
Copy link
Contributor

Bakual commented Nov 7, 2018

@anibalsanchez As I (and others) said, "most used" and "alphabetical" will not work. My approach would be a "thematic" order as I also wrote.

@dgrammatiko
Copy link
Contributor

FWIW the alphabetical order is a couple of lines change in the arrayBuilder function. Instead of returning the array as is rebuild it with the alphabetical order on the title.

Also another comment on the frequently used items: this refers to the average Joe user. Most of the people commenting here are either devs or admins. You have to change hats to understand UX from the user's point of view...

@infograf768
Copy link
Member Author

IF there will be an "average Joe user" for j4... which looks more and more reserved to an elite of site integrators.

In any case, the urgent TODO is to correct creating custom admin menus where we will need only one click to get what we frequently want, Joe user or not.

@infograf768
Copy link
Member Author

RTC as we have 2 successful tests.

The order can be changed in another PR when everyone agrees...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22957.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 8, 2018
@infograf768 infograf768 added this to the Joomla 4.0 milestone Nov 8, 2018
@wilsonge wilsonge merged commit bfca1c9 into joomla:4.0-dev Nov 8, 2018
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 8, 2018
@infograf768 infograf768 deleted the 4.0-modules_system branch November 9, 2018 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants