Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mod_languages] - no need of cache fields #23174

Merged
merged 1 commit into from Dec 1, 2018
Merged

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Nov 26, 2018

Pull Request for Issue #23166 (comment)

Summary of Changes

removed the unsed cache fields

Testing Instructions

the module works as before

p.s
cc : @infograf768

@infograf768
Copy link
Member

@infograf768 infograf768 commented Nov 27, 2018

I have tested this item successfully on d25c3cd

tks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23174.

@ghost
Copy link

@ghost ghost commented Nov 27, 2018

I have tested this item successfully on d25c3cd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23174.

@infograf768
Copy link
Member

@infograf768 infograf768 commented Nov 27, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23174.

@mbabker mbabker added this to the Joomla 3.9.2 milestone Dec 1, 2018
mbabker added a commit that referenced this pull request Dec 1, 2018
[mod_languages] - no need of cache fields
@mbabker mbabker merged commit 2c95136 into joomla:staging Dec 1, 2018
4 checks passed
4 checks passed
@joomla-cms-bot
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mbabker mbabker merged commit d25c3cd into joomla:staging Dec 1, 2018
4 checks passed
4 checks passed
@joomla-cms-bot
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alikon alikon deleted the alikon:patch-119 branch Dec 2, 2018
@klas
Copy link
Contributor

@klas klas commented Jan 19, 2019

Sorry to be late to the party, but why were this fields removed? This one was different from mod_syndicate, here caching worked and since by the itemid.

@infograf768
Copy link
Member

@infograf768 infograf768 commented Jan 19, 2019

hmm. Have'nt we suggested many users to disable the cache for this module as they were getting weird results?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants