Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Make a redirection optional for the menu item alias #23278

Merged
merged 6 commits into from
Dec 18, 2018

Conversation

csthomas
Copy link
Contributor

Pull Request for Issue #22432 (comment)

Summary of Changes

Restore the default behaviour of the menu item alias to Joomla before version 3.9

Redirection is now optional and will not work on POST request.

Testing Instructions

See comments at #22432

Expected result

See comments at #22432

Actual result

See comments at #22432

Documentation Changes Required

New language strings.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Dec 12, 2018
@sanderpotjer
Copy link
Member

I have tested this item ✅ successfully on f354ab3

@csthomas great, thanks a lot! I confirm this is restoring the "old" behaviour, and makes the redirect optional. Template style is hiding nicely when redirect is set to Yes.

Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278.

@csthomas
Copy link
Contributor Author

I have changed the order of conditions in the if statement so that I do not check the type of request in all requests.

@phproberto
Copy link
Contributor

I have tested this item ✅ successfully on 83de6dd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278.

@sanderpotjer
Copy link
Member

I have tested this item ✅ successfully on 83de6dd

Also after the latest commit, thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278.

@infograf768
Copy link
Member

RTC after 2 good tests.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 13, 2018
@infograf768 infograf768 added this to the Joomla 3.9.2 milestone Dec 13, 2018
@csthomas
Copy link
Contributor Author

I have created one more PR (#23294) to allow 3rd party extensions/custom code to create a SEF url for alias links (menu item alias)

@mbabker mbabker merged commit f98b816 into joomla:staging Dec 18, 2018
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 18, 2018
@csthomas csthomas deleted the menu_alias_choice branch December 18, 2018 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants