New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Make a redirection optional for the menu item alias #23278

Merged
merged 6 commits into from Dec 18, 2018

Conversation

Projects
None yet
7 participants
@csthomas
Copy link
Contributor

csthomas commented Dec 12, 2018

Pull Request for Issue #22432 (comment)

Summary of Changes

Restore the default behaviour of the menu item alias to Joomla before version 3.9

Redirection is now optional and will not work on POST request.

Testing Instructions

See comments at #22432

Expected result

See comments at #22432

Actual result

See comments at #22432

Documentation Changes Required

New language strings.

csthomas added some commits Dec 12, 2018

Quy and others added some commits Dec 12, 2018

Update administrator/language/en-GB/en-GB.com_menus.ini
Co-Authored-By: csthomas <csthomas@users.noreply.github.com>
@sanderpotjer

This comment has been minimized.

Copy link
Member

sanderpotjer commented Dec 12, 2018

I have tested this item successfully on f354ab3

@csthomas great, thanks a lot! I confirm this is restoring the "old" behaviour, and makes the redirect optional. Template style is hiding nicely when redirect is set to Yes.

Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278.

@csthomas

This comment has been minimized.

Copy link
Contributor Author

csthomas commented Dec 13, 2018

I have changed the order of conditions in the if statement so that I do not check the type of request in all requests.

@phproberto

This comment has been minimized.

Copy link
Contributor

phproberto commented Dec 13, 2018

I have tested this item successfully on 83de6dd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278.

@sanderpotjer

This comment has been minimized.

Copy link
Member

sanderpotjer commented Dec 13, 2018

I have tested this item successfully on 83de6dd

Also after the latest commit, thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278.

@infograf768

This comment has been minimized.

Copy link
Member

infograf768 commented Dec 13, 2018

RTC after 2 good tests.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278.

@csthomas

This comment has been minimized.

Copy link
Contributor Author

csthomas commented Dec 17, 2018

I have created one more PR (#23294) to allow 3rd party extensions/custom code to create a SEF url for alias links (menu item alias)

@mbabker mbabker merged commit f98b816 into joomla:staging Dec 18, 2018

4 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot removed the RTC label Dec 18, 2018

@csthomas csthomas deleted the csthomas:menu_alias_choice branch Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment