New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] [NO CACHE] Web Services #23424
Conversation
Merge it! |
defined('JPATH_PLATFORM') or die; | ||
|
||
/** | ||
* Exception class defining a authentication failed event |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
==> an not a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :) Fixed
/** | ||
* Exception class defining a authentication failed event | ||
* | ||
* @since 3.6.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.6.3 ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :) Fixed
Sorry to be pedantic but the correct term according to the w3c it is "Web Services" not "webservices" As this is new to Joomla its best to get it right from the beginning |
e3a131f
to
9cbc242
Compare
9cbc242
to
302291d
Compare
@brianteeman I've amended the language strings and the doc blocks where we refer to web services as a noun. I've left the plugin type as it is - because obviously it can't have spaces and i've found from practical experience with editors-xtd that most people struggle with the concept of removing the |
302291d
to
4a44683
Compare
App needs to be registered in (Side note, this method should be redone to use the event system instead of hardcoding a list...) |
* @var string | ||
* @since __DEPLOY_VERSION__ | ||
*/ | ||
protected $fieldsToRender = ['id', 'typeAlias', 'asset_id', 'title', 'introtext', 'state', 'catid', 'created']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't trust state
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
c493b01
to
33e9957
Compare
I like this, but we would indeed need at least a way to switch it off. Maybe simply adding a switch in configuration.php? |
33e9957
to
58e6c44
Compare
Thanks @alikon |
@SniperSister @zero-24 looks like still some RIPS issues - although most have been solved elsewhere |
dfeb85d
to
864ec20
Compare
Rips has been cancelled just restarted it here: http://ci.joomla.org/joomla/joomla-cms/15490 |
@zero-24 Sorry my bad I started playing around with the API tests -fixed again now. http://ci.joomla.org/joomla/joomla-cms/15495/19 contains rips |
Hello everyone .. I am interested in this project and wish to participate. Can you guide me please? |
I have exceptional skills in PHP. And a good dose of motivation. Help me please ! |
@Oracions2410 did you mean the gsoc 2019 project https://docs.joomla.org/GSOC_2019_Project_Ideas#Project_I:_Webservices_in_Joomla ? |
864ec20
to
276cb5d
Compare
Merging. Thanks again to all those who gave input, and the gsoc students who worked on this project. It's hugely appreciated! |
Yes. I just discovered the world of open source and I think Gsoc is a good start! |
@Oracions2410 that's awesome. If you drop one of the GSOC admins on that page a email they'll drop you in some of our chat channels where we can discuss details of the project etc :) |
@wilsonge |
@Oracions2410 So that we can add you to our communication channel, please drop us your email on our mailing list https://groups.google.com/forum/#!forum/jgsoc |
Preparing the talk for the Mastermind Podcast, these are my notes about Web Services quick testing 101:
For more information:
|
@Oracions2410 I am - but i was preparing for a presentation i was giving in paris so I wasn't really available. I'm now back up and running. either way however you needed to be added into glip :) |
@anibalsanchez i don't think you need to configure .htpasswd to test the api? i certainly don't need to locally. it's using the joomla user accounts username and password. apache shouldn't need to be aware of them as far as i know |
In my tests, it's been giving me Forbidden errors until I configured the auth. Carlos has a similar experience. |
Thanks everyone for this awesome feature!! I can confirm the server doesn't ask me for Username and Password as it's supposed to. I'm using a Lando box using Anibal Lando Recipe for Joomla 4 so I guess this has to do with the server configuration as stated in some comments I found on the internet about this auth method not working out of the box in CGI servers. In any case I would point out just 2 issues:
In any case, again, I was really excited with having this feature when you announced it and I event made a whole episode of my podcast about it because it's awesome to keep creating great solutions for our community and our clients. |
Wait are you making requests in the browser or something? Nothing is supposed to prompt you for a password? |
I already told him that he has to configure the .htpassword file to enable the Apache Http Basic Authentication. I agree with Carlos that if the plugin is enabled, then public content (articles) must be allowed to the Guest user. |
This is a base for a web services implementation for Joomla 4
What this has got in
Core
Integrations/Testing
What does this not have in
Thanks
Before moaning about a lack of feature X
Please read the specification https://joomla-projects.github.io/gsoc18_webservices/ - this has long been agreed on and is by no means perfect. Think about if it's absolutely essential for a day 1 integration or not. What we have in this PR is already significantly more than wordpress has and is probably equal to what's available in the other top level CMS'
Testing