New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_joomlaupdate] restore vs php 7.3 #23481

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
None yet
8 participants
@alikon
Copy link
Contributor

alikon commented Jan 8, 2019

Pull Request for Issue #23266

Summary of Changes

break vs continue for php 7.3.

Testing Instructions

on php 7.3 no more that warning

@zero-24

zero-24 approved these changes Jan 8, 2019

@pmleconte

This comment has been minimized.

Copy link

pmleconte commented Jan 12, 2019

I have tested this item successfully on 63355e0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23481.

1 similar comment
@viocassel

This comment has been minimized.

Copy link
Contributor

viocassel commented Jan 13, 2019

I have tested this item successfully on 63355e0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23481.

@Quy

This comment has been minimized.

Copy link
Contributor

Quy commented Jan 13, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23481.

@joomla-cms-bot joomla-cms-bot added the RTC label Jan 13, 2019

@laoneo

laoneo approved these changes Jan 14, 2019

@mbabker mbabker added this to the Joomla 3.9.2 milestone Jan 15, 2019

@mbabker mbabker merged commit 34faac6 into joomla:staging Jan 15, 2019

4 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels Jan 15, 2019

@alikon alikon deleted the alikon:patch-109 branch Jan 15, 2019

crowncodes added a commit to crowncodes/joomla-cms that referenced this pull request Jan 16, 2019

Latest (#1)
* Multilang: correcting `Published Request Form Menu Item` url in Privacy Dashboard (joomla#22909)

* Multilang: correcting Published Request Form Menu Item url in Privacy
Dashboard

* correction

* Correcting Itemid when no menu item

* php 5.3 compatibility

*  Updated installation language files for german dialects (joomla#23492)

* Updated installation language files for german dialects

* fix author

; Joomla! Project

* Privacy dashboard: direct access to the privacy consent plugin (joomla#22888)

* Privacy dashboard: direct access to the privacy consent plugin

* oops

* namespacing

* s forgotten in new ini string

* Prepare 3.9.2 release candidate

* Reset for dev

* Duplicate String and not to be deprecated. (joomla#23513)

* [com_joomlaupdate] restore vs php 7.3 (joomla#23481)

* Prepare 3.9.2 release

* Reset for dev

* Fixed small typos in months of Joomla core extension (joomla#23552)

crowncodes added a commit to crowncodes/joomla-cms that referenced this pull request Jan 16, 2019

Update (#2)
* Multilang: correcting `Published Request Form Menu Item` url in Privacy Dashboard (joomla#22909)

* Multilang: correcting Published Request Form Menu Item url in Privacy
Dashboard

* correction

* Correcting Itemid when no menu item

* php 5.3 compatibility

*  Updated installation language files for german dialects (joomla#23492)

* Updated installation language files for german dialects

* fix author

; Joomla! Project

* Privacy dashboard: direct access to the privacy consent plugin (joomla#22888)

* Privacy dashboard: direct access to the privacy consent plugin

* oops

* namespacing

* s forgotten in new ini string

* Prepare 3.9.2 release candidate

* Reset for dev

* Duplicate String and not to be deprecated. (joomla#23513)

* [com_joomlaupdate] restore vs php 7.3 (joomla#23481)

* Prepare 3.9.2 release

* Reset for dev

* Fixed small typos in months of Joomla core extension (joomla#23552)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment