Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate String and not to be deprecated. #23513

Merged
merged 1 commit into from Jan 12, 2019

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Jan 11, 2019

Somehow we ended up with a dupicate language string, the second one having a deprecation note.

Summary of Changes

Since the string is still used both in J3 and J4, this PR removes the second appearance together with the note.

Testing Instructions

The button where this text is used isn't visible by default. It gets hidden by JS once the drag area in the extension installer view is loaded. I guess it would be visible if JS is disabled or broken or whatever.
You can see it in the source code thought.

Expected result

Text is there.

Actual result

Text is there, but string is doubled in the INI file

Documentation Changes Required

None

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Jan 11, 2019
@Quy
Copy link
Contributor

Quy commented Jan 11, 2019

I have tested this item ✅ successfully on a1cc2da


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23513.

@infograf768 infograf768 merged commit c17bfc4 into joomla:staging Jan 12, 2019
@infograf768
Copy link
Member

Thanks Mig for finding this out.

@Bakual Bakual deleted the DuplicateString branch January 12, 2019 11:24
@zero-24 zero-24 added this to the Joomla 3.9.2 milestone Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants