New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single contact - show contact name #23563
Conversation
The option to display the contact name was inside the "contact information" options and was only visible to set if the "contact information" was set to "show" It shouldn't be connected to the "contact information" as the display of th contct name is not conditional on the display of the contact informttion This simple PR moves the field out of the contact information block and condition Created this PR as it took me ages to finnd the option to remove the contact name from the page as the option was hidden ;)
I have tested this item ✅ successfully on 85d4166 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563. |
I have tested this item 🔴 unsuccessfully on 85d4166 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563. |
I do not see any change in order of the options (Global configuration > Contacts) after applying this patch. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563. |
I have tested this item 🔴 unsuccessfully on 85d4166 tested succesfully for category/tmp/default.xml and contact/tmp/deault.xml. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563. |
Hi, tested succesfully for category/tmp/default.xml and contact/tmp/deault.xml. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563. |
bugs and conflicts fixed |
I have tested this item ✅ successfully on 45cf4e7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563. |
1 similar comment
I have tested this item ✅ successfully on 45cf4e7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563. |
I have tested this item 🔴 unsuccessfully on 45cf4e7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563. |
It's not a matter of Global Configuration > Contacts. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563. |
I have tested this item ✅ successfully on 45cf4e7
|
thx |
thanks |
useglobal="true" | ||
class="chzn-color" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont' think you meant to remove this class
The option to display the contact name was inside the "contact information" options and was only visible to set if the "contact information" was set to "show"
It shouldn't be connected to the "contact information" as the display of the contact name is not conditional on the display of the contact information
This simple PR moves the field out of the contact information block and condition
Created this PR as it took me ages to find the option to remove the contact name from the page as the option was hidden ;)