Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single contact - show contact name #23563

Merged
merged 5 commits into from Feb 28, 2019

Conversation

Projects
None yet
8 participants
@brianteeman
Copy link
Contributor

brianteeman commented Jan 16, 2019

The option to display the contact name was inside the "contact information" options and was only visible to set if the "contact information" was set to "show"

It shouldn't be connected to the "contact information" as the display of the contact name is not conditional on the display of the contact information

This simple PR moves the field out of the contact information block and condition

Created this PR as it took me ages to find the option to remove the contact name from the page as the option was hidden ;)

Single contact - show contact name
The option to display the contact name was inside the "contact information" options and was only visible to set if the "contact information" was set to "show"

It shouldn't be connected to the "contact information" as the display of th contct name is not conditional on the display of the contact informttion

This simple PR moves the field out of the contact information block and condition

Created this PR as it took me ages to finnd the option to remove the contact name from the page as the option was hidden ;)
@viocassel

This comment has been minimized.

Copy link
Contributor

viocassel commented Jan 27, 2019

I have tested this item successfully on 85d4166


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@kofaysi

This comment has been minimized.

Copy link

kofaysi commented Feb 8, 2019

I have tested this item 🔴 unsuccessfully on 85d4166

I do not see any change in option order (Global Configuration > Contacts) after applying the patch on J 3.9.2
contact info hide
contact info show


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@kofaysi

This comment has been minimized.

Copy link

kofaysi commented Feb 8, 2019

I do not see any change in order of the options (Global configuration > Contacts) after applying this patch.
contact info hide
contact info show


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@ladyjer

This comment has been minimized.

Copy link
Contributor

ladyjer commented Feb 24, 2019

I have tested this item 🔴 unsuccessfully on 85d4166

Hi,

tested succesfully for category/tmp/default.xml and contact/tmp/deault.xml.
tested unsucessfully for categories/tmpl/default.xml. Order now is ok but still present "showon="show_info:1" for name field.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@ladyjer

This comment has been minimized.

Copy link
Contributor

ladyjer commented Feb 24, 2019

Hi,

tested succesfully for category/tmp/default.xml and contact/tmp/deault.xml.
tested unsucessfully for categories/tmpl/default.xml. Order now is ok but still present "showon="show_info:1" for name field.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

brianteeman added some commits Feb 24, 2019

@brianteeman

This comment has been minimized.

Copy link
Contributor Author

brianteeman commented Feb 24, 2019

bugs and conflicts fixed

@viocassel

This comment has been minimized.

Copy link
Contributor

viocassel commented Feb 24, 2019

I have tested this item successfully on 45cf4e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

1 similar comment
@ladyjer

This comment has been minimized.

Copy link
Contributor

ladyjer commented Feb 24, 2019

I have tested this item successfully on 45cf4e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@Quy

This comment has been minimized.

Copy link
Contributor

Quy commented Feb 24, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@joomla-cms-bot joomla-cms-bot added the RTC label Feb 24, 2019

@kofaysi

This comment has been minimized.

Copy link

kofaysi commented Feb 25, 2019

I have tested this item 🔴 unsuccessfully on 45cf4e7

I do not see any change in option order (Global Configuration > Contacts) after applying the patch on J3.9.3.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@ladyjer

This comment has been minimized.

Copy link
Contributor

ladyjer commented Feb 25, 2019

It's not a matter of Global Configuration > Contacts.
The issue is about option on menu item on contacts/contact category/contact categories


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@kofaysi

This comment has been minimized.

Copy link

kofaysi commented Feb 25, 2019

I have tested this item successfully on 45cf4e7

Ok, I see now. What is the reason for

  • leaving the other contact details (Contact's Position, Email, Street Address, City or Suburb, State or County, Postal/ZIP Code, Country, Telephone, Mobile Phone, Fax, Webpage, Image) - or at least dealing with bulks: Position, Email, Address, Phones, Webpage; or
  • not changing the visible also in the Global configuration if

It shouldn't be connected to the "contact information" as the display of the contact name is not conditional on the display of the contact information


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@HLeithner HLeithner merged commit dfd1181 into joomla:staging Feb 28, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot removed the RTC label Feb 28, 2019

@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Feb 28, 2019

thx

@HLeithner HLeithner added this to the Joomla 3.9.4 milestone Feb 28, 2019

@brianteeman

This comment has been minimized.

Copy link
Contributor Author

brianteeman commented Feb 28, 2019

thanks

@brianteeman brianteeman deleted the brianteeman:contact_name branch Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.