Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single contact - show contact name #23563

Merged
merged 5 commits into from Feb 28, 2019
Merged

Conversation

brianteeman
Copy link
Contributor

The option to display the contact name was inside the "contact information" options and was only visible to set if the "contact information" was set to "show"

It shouldn't be connected to the "contact information" as the display of the contact name is not conditional on the display of the contact information

This simple PR moves the field out of the contact information block and condition

Created this PR as it took me ages to find the option to remove the contact name from the page as the option was hidden ;)

The option to display the contact name was inside the "contact information" options and was only visible to set if the "contact information" was set to "show"

It shouldn't be connected to the "contact information" as the display of th contct name is not conditional on the display of the contact informttion

This simple PR moves the field out of the contact information block and condition

Created this PR as it took me ages to finnd the option to remove the contact name from the page as the option was hidden ;)
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 85d4166


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@kofaysi
Copy link
Contributor

kofaysi commented Feb 8, 2019

I have tested this item 🔴 unsuccessfully on 85d4166

I do not see any change in option order (Global Configuration > Contacts) after applying the patch on J 3.9.2
contact info hide
contact info show


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@kofaysi
Copy link
Contributor

kofaysi commented Feb 8, 2019

I do not see any change in order of the options (Global configuration > Contacts) after applying this patch.
contact info hide
contact info show


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@ladyjer
Copy link
Contributor

ladyjer commented Feb 24, 2019

I have tested this item 🔴 unsuccessfully on 85d4166

Hi,

tested succesfully for category/tmp/default.xml and contact/tmp/deault.xml.
tested unsucessfully for categories/tmpl/default.xml. Order now is ok but still present "showon="show_info:1" for name field.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@ladyjer
Copy link
Contributor

ladyjer commented Feb 24, 2019

Hi,

tested succesfully for category/tmp/default.xml and contact/tmp/deault.xml.
tested unsucessfully for categories/tmpl/default.xml. Order now is ok but still present "showon="show_info:1" for name field.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@brianteeman
Copy link
Contributor Author

bugs and conflicts fixed

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 45cf4e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

1 similar comment
@ladyjer
Copy link
Contributor

ladyjer commented Feb 24, 2019

I have tested this item ✅ successfully on 45cf4e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@Quy
Copy link
Contributor

Quy commented Feb 24, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 24, 2019
@kofaysi
Copy link
Contributor

kofaysi commented Feb 25, 2019

I have tested this item 🔴 unsuccessfully on 45cf4e7

I do not see any change in option order (Global Configuration > Contacts) after applying the patch on J3.9.3.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@ladyjer
Copy link
Contributor

ladyjer commented Feb 25, 2019

It's not a matter of Global Configuration > Contacts.
The issue is about option on menu item on contacts/contact category/contact categories


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@kofaysi
Copy link
Contributor

kofaysi commented Feb 25, 2019

I have tested this item ✅ successfully on 45cf4e7

Ok, I see now. What is the reason for

  • leaving the other contact details (Contact's Position, Email, Street Address, City or Suburb, State or County, Postal/ZIP Code, Country, Telephone, Mobile Phone, Fax, Webpage, Image) - or at least dealing with bulks: Position, Email, Address, Phones, Webpage; or
  • not changing the visible also in the Global configuration if

It shouldn't be connected to the "contact information" as the display of the contact name is not conditional on the display of the contact information


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

@HLeithner HLeithner merged commit dfd1181 into joomla:staging Feb 28, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 28, 2019
@HLeithner
Copy link
Member

thx

@HLeithner HLeithner added this to the Joomla 3.9.4 milestone Feb 28, 2019
@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the contact_name branch February 28, 2019 15:16
useglobal="true"
class="chzn-color"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont' think you meant to remove this class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants