Featured articles page subheading #23583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The featured articles view is intended to be identical to the blog view. The only differences are because it is not purely based on category selection but also on the featured attribute of an article. The blog view has a page_subheading option but this is missing from the featured view. This PR adds the page_subheading to that view so that the two views are as consistent as possible. ### Testing Create a blog and a featured view Add a page subheading - you will find the option in the menu. For featured it is at the bottom of the Layout tab. For blog it is at the bottom o the category tab (I think thats wrong but is beyond the scope of this PR) You will now see the subheading in an h2 tag at the top of the page (below the page title if set) I see this as a bug not a new feature as stated above
|
I agree with this PR but would like to have a dependecy between show_title and subtitle (showon). In my opinion, a subtitle makes ony sense when there is a title. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23583. |
|
That is beyond the scope of this pr. |
|
Adding that dependency would make it a new feature as there would be b/c issues |
|
thx |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The featured articles view is intended to be identical to the blog view. The only differences are because it is not purely based on category selection but also on the featured attribute of an article.
The blog view has a page_subheading option but this is missing from the featured view. This PR adds the page_subheading to that view so that the two views are as consistent as possible.
Testing
Create a blog and a featured view
Add a page subheading - you will find the option in the menu. For featured it is at the bottom of the Layout tab. For blog it is at the bottom o the category tab (I think thats wrong but is beyond the scope of this PR)
You will now see the subheading in an h2 tag at the top of the page (below the page title if set)
I see this as a bug not a new feature as stated above