Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured articles page subheading #23583

Merged
merged 1 commit into from Feb 22, 2019

Conversation

Projects
None yet
4 participants
@brianteeman
Copy link
Contributor

brianteeman commented Jan 18, 2019

The featured articles view is intended to be identical to the blog view. The only differences are because it is not purely based on category selection but also on the featured attribute of an article.

The blog view has a page_subheading option but this is missing from the featured view. This PR adds the page_subheading to that view so that the two views are as consistent as possible.

Testing

Create a blog and a featured view
Add a page subheading - you will find the option in the menu. For featured it is at the bottom of the Layout tab. For blog it is at the bottom o the category tab (I think thats wrong but is beyond the scope of this PR)
You will now see the subheading in an h2 tag at the top of the page (below the page title if set)

I see this as a bug not a new feature as stated above

Featured articles page subheading
The featured articles view is intended to be identical to the blog view. The only differences are because it is not purely based on category selection but also on the featured attribute of an article.

The blog view has a page_subheading option but this is missing from the featured view. This PR adds the page_subheading to that view so that the two views are as consistent as possible.

### Testing
Create a blog and a featured view
Add a page subheading - you will find the option in the menu. For featured it is at the bottom of the Layout tab. For blog it is at the bottom o the category tab (I think thats wrong but is beyond the scope of this PR)
You will now see the subheading in an h2 tag at the top of the page (below the page title if set)

I see this as a bug not a new feature as stated above
@chmst

This comment has been minimized.

Copy link
Contributor

chmst commented Jan 20, 2019

I agree with this PR but would like to have a dependecy between show_title and subtitle (showon). In my opinion, a subtitle makes ony sense when there is a title.
And I agree that this is the same for categories - if there is no b/c reason, another PR could bring the field into the page display tab.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23583.

@brianteeman

This comment has been minimized.

Copy link
Contributor Author

brianteeman commented Jan 20, 2019

That is beyond the scope of this pr.

@brianteeman

This comment has been minimized.

Copy link
Contributor Author

brianteeman commented Feb 21, 2019

Adding that dependency would make it a new feature as there would be b/c issues

@HLeithner HLeithner merged commit 6ff86c5 into joomla:staging Feb 22, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Feb 22, 2019

thx

@HLeithner HLeithner added this to the Joomla 3.9.4 milestone Feb 22, 2019

@brianteeman

This comment has been minimized.

Copy link
Contributor Author

brianteeman commented Feb 22, 2019

Thanks

@brianteeman brianteeman deleted the brianteeman:subheading branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.