Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix wrong error message on connecting mysql #23764

Merged
merged 10 commits into from Mar 16, 2019

Conversation

hardik-codes
Copy link
Contributor

Pull Request for Issue #22961

Summary of Changes

Changed the error message.

Testing Instructions

On installing Joomla 4.0, the error message appears on the Database Configuration screen when the installer fails to connect to mysql

Expected result

A sensible error message

mysql_error

Actual result

mysql_error original

Documentation Changes Required

None

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Feb 4, 2019
@hardik-codes
Copy link
Contributor Author

hardik-codes commented Mar 7, 2019

@infograf768 @PhilETaylor please review this PR

@infograf768
Copy link
Member

I have tested this item ✅ successfully on f9b8007


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23764.

@hardik-codes
Copy link
Contributor Author

One more tester please

@Quy
Copy link
Contributor

Quy commented Mar 15, 2019

I have tested this item ✅ successfully on f9b8007


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23764.

@Quy
Copy link
Contributor

Quy commented Mar 15, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23764.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 15, 2019
@infograf768 infograf768 merged commit b98674b into joomla:4.0-dev Mar 16, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 16, 2019
@infograf768 infograf768 added this to the Joomla 4.0 milestone Mar 16, 2019
@infograf768
Copy link
Member

Thanks

@hardik-codes hardik-codes deleted the sqlError branch April 18, 2019 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants