-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] [a11y] aria-describedby when field has a description #23919
Conversation
The aria-described-by was in the wrong place and there was an unneeded title attribute This was reported by @zwiastunsw I am working through the fields fields included so far - list - number - text - textarea
@brianteeman one thing to consider here: this description in J3 used to be the tooltip of each field. Some texts are way too long and probably inappropriate for an Maybe for the shake of B/C we should leave this as is (and use it in the new tooltips, activated on mouse over a field, or on field focus) and introduce another attribute, eg FWIW I'm not against what you're doing here, just thinking what will be the less painful approach here... |
@dgrammatiko I would much prefer it if peo0ple could SEE those crazy long tips and submit pr to change them to something other than a manual |
@brianteeman and we both know that some will resist those changes... |
After the changes the descriptions are read by the screen reader. Perfectly. |
I have tested this item ✅ successfully on e38aaa4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23919. |
@brianteeman Please, correct PR title: |
@zwiastunsw Thanks for testing the work so far. I will continue on this tomorrow to make sure that all fields have this functionality even if the core doesnt use it |
Thanks -missed this one Co-Authored-By: brianteeman <brian@teeman.net>
@brianteeman the code needs some cleanup and fixing the positioning: https://codepen.io/dgrammatiko/pen/eGELjo |
@dgrammatiko looks good. We need this for the search tips. If you create a pr that would be awesome |
@brianteeman cans you please cancel the new variable?
becomes
Rule of thumb: declare a new variable only if you're gonna use it more than once, else you just adding more memory allocation for the app |
We also need it for buttons - font icons (without label). |
updated pr as requested |
Co-Authored-By: brianteeman <brian@teeman.net>
When in an array, no need to add a leading space since it will be imploded later with a space. This should also be fixed in |
Co-Authored-By: brianteeman <brian@teeman.net>
Co-Authored-By: brianteeman <brian@teeman.net>
Co-Authored-By: brianteeman <brian@teeman.net>
Co-Authored-By: brianteeman <brian@teeman.net>
Co-Authored-By: brianteeman <brian@teeman.net>
Co-Authored-By: brianteeman <brian@teeman.net>
@wilsonge can you merge this one as well please. There won't be any more fields added to this PR as the remaining ones require js |
I don't have permission to your repo to merge in 4.0. so yes - but i need you to sync up with 4.0 please |
@wilsonge should be ok now |
waiting for rips to be sorted but intention is to merge this next |
OK - thanks |
Thanks! |
Thanks |
How to make radio buttons a11y or is it already as is? There is id
|
The aria-described-by was in the wrong place and there was an unneeded title attribute
This was reported by @zwiastunsw #23896
I am working through the fields
fields included so far
NOTE - this change will need to be done for all field layouts even if core doesnt have any cases where there is a description