[4.0] Warning message : JUser: :_load: Unable to load user with ID #24166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR for joomla#20689 The error message displayed when the user cannot be found (eg when opening a content item when the content creator has been deleted) is not meaningful. Keeping it simple and in line with other error messages I propose changing it to > Unable to find a user with the ID: %s
ghost
mentioned this pull request
|
This makes a lot more sense. Thanks! |
|
Thanks |
|
The changed message is good.. However as suggested in this issue https://issues.joomla.org/tracker/joomla-cms/20689 we should only show this - say if Debug is on.. As while it could be useful to administrators showing this in the frontend might not be a good idea even if the message is changed. I think the use case here is that the JUser object is being used to load things like the Usernmame/Name instead of doing direct queries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #20689
The error message displayed when the user cannot be found (eg when opening a content item when the content creator has been deleted) is not meaningful.
Keeping it simple and in line with other error messages I propose changing it to