Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting Associations tab display when using Indonesian id-ID language #24244

Merged
merged 2 commits into from Mar 21, 2019

Conversation

Projects
None yet
5 participants
@infograf768
Copy link
Member

infograf768 commented Mar 19, 2019

Pull Request for Issue #24239

Summary of Changes

Modifying js to cope with the id-ID language tag

Thanks Robbie Jackson !

Testing Instructions

See #24239

Before patch

Screen Shot 2019-03-19 at 15 21 36

After patch

Screen Shot 2019-03-19 at 15 19 51

@Geoplous

This comment has been minimized.

Copy link

Geoplous commented Mar 20, 2019

I have tested this item successfully on 8a4a79d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24244.

@imanickam

This comment has been minimized.

Copy link
Contributor

imanickam commented Mar 20, 2019

I have tested this item successfully on 8a4a79d

Tested successfully on Joomla! 3.9.4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24244.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.9.5 milestone Mar 20, 2019

@infograf768

This comment has been minimized.

Copy link
Member Author

infograf768 commented Mar 20, 2019

RTC
Thanks for testing.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24244.

@joomla-cms-bot joomla-cms-bot added the RTC label Mar 20, 2019

@infograf768 infograf768 added this to the Joomla 3.9.5 milestone Mar 20, 2019

@zero-24 zero-24 merged commit e34b632 into joomla:staging Mar 21, 2019

4 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot removed the RTC label Mar 21, 2019

@zero-24

This comment has been minimized.

Copy link
Contributor

zero-24 commented Mar 21, 2019

Merging thanks.

@infograf768 infograf768 deleted the infograf768:indonesiantagissue branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.