Fix page-break-inside (template menu assignment) #24345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have to update the css file. |
|
My bad. LESS has been compiled. Im getting mixed up with 4. I guess this can be tested with patchtester. |
ghost
changed the title
|
I have tested this item ✅ successfully on a993dea This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24345. |
|
I have tested this item ✅ successfully on a993dea This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24345. |
|
Status "Ready To Commit". This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24345. |
|
thx |
|
@franz-wohlkoenig @alikon thank you for the tests |
tecpromotion
pushed a commit
to tecpromotion/joomla-cms
that referenced
this pull request
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #24344 .
Summary of Changes
In firefox menus are been split across columns in the template menu assignment tab
Testing Instructions
Have less than 4 menus. Navigate to template style menu assignment tab. Note if using sample data, it is probably easier to just delete the extra li nodes to display less than 4 menus (browser tools).
Before
After
Documentation Changes Required